[Page Load Metrics] Add page load metrics for omnibox.

[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)

Review-Url: https://codereview.chromium.org/2802833002
Cr-Commit-Position: refs/branch-heads/3029@{#617}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/4981296103dd498f1dd18329d39a58006caa9394

[lpy, 2017-04-05 22:06:07]

lpy@chromium.org changed reviewers:
+ bmcquade@chromium.org, mpearson@chromium.org

[lpy, 2017-04-05 22:06:08]

This is a cherry-pick to land omnibox page load metrics to M58. Nothing is
different from the other CL, I think I will need lgtm in order to land it.

[Bryan McQuade, 2017-04-06 13:40:46]

On 2017/04/05 at 22:06:08, lpy wrote:
> This is a cherry-pick to land omnibox page load metrics to M58. Nothing is
different from the other CL, I think I will need lgtm in order to land it.

Thanks. Can you confirm that you're able to build the chrome binary? Once you've
been able to build this is fine to land.

[pasko, 2017-04-06 13:48:06]

On 2017/04/06 13:40:46, Bryan McQuade wrote:
> On 2017/04/05 at 22:06:08, lpy wrote:
> > This is a cherry-pick to land omnibox page load metrics to M58. Nothing is
> different from the other CL, I think I will need lgtm in order to land it.
> 
> Thanks. Can you confirm that you're able to build the chrome binary? Once
you've
> been able to build this is fine to land.

Most cherry-picks land without this check. It is tedious to check it on every
platform, so unless something non-trivial is done to resolve merge conflicts, I
would recommend to land and watch the official builders.

[pasko, 2017-04-06 13:48:24]

Description was changed from

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)
==========

to

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)
==========

[Bryan McQuade, 2017-04-06 13:51:03]

On 2017/04/06 at 13:48:06, pasko wrote:
> On 2017/04/06 13:40:46, Bryan McQuade wrote:
> > On 2017/04/05 at 22:06:08, lpy wrote:
> > > This is a cherry-pick to land omnibox page load metrics to M58. Nothing is
> > different from the other CL, I think I will need lgtm in order to land it.
> > 
> > Thanks. Can you confirm that you're able to build the chrome binary? Once
you've
> > been able to build this is fine to land.
> 
> Most cherry-picks land without this check. It is tedious to check it on every
platform, so unless something non-trivial is done to resolve merge conflicts, I
would recommend to land and watch the official builders.

Ok. I always build, and sometimes find build failures. I think it's poor
practice to land a change w/o building but if you think that's appropriate, we
can submit.

[Bryan McQuade, 2017-04-06 13:51:06]

lgtm

[Bryan McQuade, 2017-04-06 13:57:41]

On 2017/04/06 at 13:51:06, Bryan McQuade wrote:
> lgtm

Egor and I chatted briefly - lpy if you are able to build in the branch I think
it'd be slightly better to be certain this builds in the branch before landing.
If it's high overhead to do so I am not opposed to landing w/o building.

[lpy, 2017-04-06 16:37:47]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 16:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:38:18]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[lpy, 2017-04-06 20:56:49]

On 2017/04/06 13:57:41, Bryan McQuade wrote:
> On 2017/04/06 at 13:51:06, Bryan McQuade wrote:
> > lgtm
> 
> Egor and I chatted briefly - lpy if you are able to build in the branch I
think
> it'd be slightly better to be certain this builds in the branch before
landing.
> If it's high overhead to do so I am not opposed to landing w/o building.

I can compile on my local machine, does it count?

[lpy, 2017-04-06 21:40:50]

@Mark could you take a look?

[Mark P, 2017-04-06 22:13:46]

lgtm

(I assume this is the same as the patch you submitted to top-of-tree.)

--mark

[lpy, 2017-04-06 22:14:20]

On 2017/04/06 22:13:46, Mark P wrote:
> lgtm
> 
> (I assume this is the same as the patch you submitted to top-of-tree.)
> 
> --mark

Yes it is.

[lpy, 2017-04-06 22:14:25]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:15:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:15:49]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[lpy, 2017-04-06 23:01:58]

Description was changed from

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)
==========

to

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)
==========

[lpy, 2017-04-06 23:02:03]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:03:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:06:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491519723414590, "parent_rev":
"7832e106ed7e343da9583d92f325faa5bc21a2ae", "commit_rev":
"4981296103dd498f1dd18329d39a58006caa9394"}

[commit-bot: I haz the power, 2017-04-06 23:07:40]

Description was changed from

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)
==========

to

==========
[Page Load Metrics] Add page load metrics for omnibox.

Add metrics to track time to first contentful/meaningful paint from pages
where users select suggestion from omnibox.

BUG=702440
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2744983002
Cr-Commit-Position: refs/heads/master@{#461621}
(cherry picked from commit 71bcf50b0c34114c514e431af16527792c55006a)

Review-Url: https://codereview.chromium.org/2802833002
Cr-Commit-Position: refs/branch-heads/3029@{#617}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/4981296103dd498f1dd18329d39a...
==========

[commit-bot: I haz the power, 2017-04-06 23:07:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4981296103dd498f1dd18329d39a...