Source/core/frame/LocalFrame.cpp - Issue 280283002: Stop firing orientationchange events at pages that are not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 280283002: Stop firing orientationchange events at pages that are not visible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase now that dependency patch has landed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 09c78c8d4f8ed7b0cb884c85ee56f153ecf98978..63708d4c0660f072ea9ce54de598d8592360e1b8 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -167,6 +167,10 @@ void LocalFrame::sendOrientationChangeEvent()

if (!RuntimeEnabledFeatures::orientationEventEnabled() && !RuntimeEnabledFeatures::screenOrientationEnabled())

return;

+ // Don't fire 'orientationchange' events at pages that are not visible.

mlamouri (slow - plz ping) 2014/05/28 14:05:33 nit: I'm pretty sure the code is self explanatory

Inactive 2014/05/28 15:27:28 Done.

+ if (page()->visibilityState() != PageVisibilityStateVisible)

+ return;

DOMWindow* window = domWindow();

if (!window)

return;