Chromium Code Reviews Chromium Code Reviews
Issue 280283002:
Stop firing orientationchange events at pages that are not visible (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/screen_orientation/page-visibility.html |
| diff --git a/LayoutTests/screen_orientation/page-visibility.html b/LayoutTests/screen_orientation/page-visibility.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..51eb828deeb0652f7f089f677612fedf30f588b8 |
| --- /dev/null |
| +++ b/LayoutTests/screen_orientation/page-visibility.html |
| @@ -0,0 +1,45 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<body> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script> |
| +var orientationChangeEventListenerCalls = 0; |
| + |
| +window.addEventListener('orientationchange', function() { |
| + orientationChangeEventListenerCalls++; |
| +}); |
| + |
| +test(function() { |
| + assert_false(document.hidden); |
| + if (window.testRunner) |
| + window.testRunner.setMockScreenOrientation("landscape-primary"); |
| + assert_equals(orientationChangeEventListenerCalls, 1); |
| + assert_equals(screen.orientation, "landscape-primary"); |
| +}, "Test that 'orientationchange' event is fired when the page is visible"); |
| + |
| +if (window.testRunner) |
| + testRunner.setPageVisibility("hidden"); |
| + |
| +test(function() { |
| + assert_true(document.hidden); |
| + if (window.testRunner) |
| + window.testRunner.setMockScreenOrientation("portrait-primary"); |
| + assert_equals(orientationChangeEventListenerCalls, 1); |
| +}, "Test that 'orientationchange' event is not fired when the page is not visible"); |
| + |
| +test(function() { |
| + assert_equals(screen.orientation, "landscape-primary"); |
| +}, "Test that screen.orientation keeps returning the same orientation when the page is not visible"); |
| + |
| +if (window.testRunner) |
| + testRunner.setPageVisibility("visible"); |
| + |
| +test(function() { |
| + assert_false(document.hidden); |
| + // Should keep returning the start returning the orientation value. |
| + assert_equals(screen.orientation, "portrait-primary"); |
|
mlamouri (slow - plz ping)
2014/05/28 14:05:33
We should test that an event has been fired too.
Inactive
2014/05/28 15:27:28
Done.
|
| +}, "Test that screen.orientation is updated once the page is visible again"); |
| +</script> |
| +</body> |
| +</html> |
