Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2802783003:
❄ Unify infobar spannable creation (Closed)
Description❄ Unify infobar spannable creation
Infobars were creating spannable links in two different ways.
Unify them. Note that this means that no links (except the
weirdo ones in the translate infobars) will be underlined;
apparently this is how they were specced.
BUG=705312
Review-Url: https://codereview.chromium.org/2802783003
Cr-Commit-Position: refs/heads/master@{#462337}
Committed: https://chromium.googlesource.com/chromium/src/+/0a929145b1f3d51656a53582749a90123528963b
Patch Set 1 #
Total comments: 2
Patch Set 2 : ❄ Unify spannable creation #Messages
Total messages: 19 (13 generated)
Description was changed from ========== ❄ Unify spannable creation Infobars were creating spannable links in two different ways. Unify them. BUG=705312 ========== to ========== ❄ Unify infobar spannable creation Infobars were creating spannable links in two different ways. Unify them. Note that this means that no links (except the weirdo ones in the translate infobars) will be underlined; apparently this is how they were specced. BUG=705312 ==========
dfalcantara@chromium.org changed reviewers: + twellington@chromium.org
Theresa: PTAL
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2802783003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java (right): https://codereview.chromium.org/2802783003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:504: private ClickableSpan createClickableSpan() { Can this use NoUnderlineClickableSpan.java and skip overriding onDrawState()?
https://codereview.chromium.org/2802783003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java (right): https://codereview.chromium.org/2802783003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:504: private ClickableSpan createClickableSpan() { On 2017/04/06 00:22:06, Theresa wrote: > Can this use NoUnderlineClickableSpan.java and skip overriding onDrawState()? Sweet find.
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by dfalcantara@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491447625987090,
"parent_rev": "d733a593aa9ae75a43686ed421f21b039df51fbb", "commit_rev":
"0a929145b1f3d51656a53582749a90123528963b"}
Message was sent while issue was closed.
Description was changed from ========== ❄ Unify infobar spannable creation Infobars were creating spannable links in two different ways. Unify them. Note that this means that no links (except the weirdo ones in the translate infobars) will be underlined; apparently this is how they were specced. BUG=705312 ========== to ========== ❄ Unify infobar spannable creation Infobars were creating spannable links in two different ways. Unify them. Note that this means that no links (except the weirdo ones in the translate infobars) will be underlined; apparently this is how they were specced. BUG=705312 Review-Url: https://codereview.chromium.org/2802783003 Cr-Commit-Position: refs/heads/master@{#462337} Committed: https://chromium.googlesource.com/chromium/src/+/0a929145b1f3d51656a53582749a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0a929145b1f3d51656a53582749a... |
