List all a11y features in a11y detailed view in ash system menu

List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

Changes in this CL,

1. Add four functions in AccessibilityDelegate interface.
   This is used to show above two a11y features in system menu.

BUG=632107
Review-Url: https://codereview.chromium.org/2802783002
Cr-Commit-Position: refs/heads/master@{#462961}
Committed: https://chromium.googlesource.com/chromium/src/+/d9d54248e86613a858bc8cefacd5725fd9aafc7f

[minch1, 2017-04-05 18:18:41]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:19:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[minch1, 2017-04-05 18:58:14]

Description was changed from

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging


BUG=632107
==========

to

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging


BUG=632107
==========

[minch1, 2017-04-05 18:58:15]

minch@chromium.org changed reviewers:
+ tdanderson@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:00:46]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-04-05 19:01:02]

Hi, tdanderson@, can you help review? Thanks.

[tdanderson, 2017-04-05 20:42:17]

Thanks for taking care of these last two settings!

ash/common/system
ash/common/metrics
ash/metrics

all LGTM.

https://codereview.chromium.org/2802783002/diff/1/ash/ash_strings.grd
File ash/ash_strings.grd (right):

https://codereview.chromium.org/2802783002/diff/1/ash/ash_strings.grd#newcode8
ash/ash_strings.grd:8: output_all_resource_defines="false" source_lang_id="en"
enc_check="möl">
nit: In your CL description can you also mention that you're adding to the
AccessibilityDelegate interface in addition to showing these features in the
system menu? In general it's helpful for reviewers / other developers if the CL
description is used to give a brief overview of all the major changes in a CL.

[minch1, 2017-04-05 21:02:01]

Description was changed from

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging


BUG=632107
==========

to

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

This cl adds four functions in AccessibilityDelegate abstract class. This is
used to show above two a11y features in system menu.

BUG=632107
==========

[minch1, 2017-04-05 21:04:15]

minch@chromium.org changed reviewers:
+ jwd@chromium.org, oshima@chromium.org

[minch1, 2017-04-05 21:04:47]

Hi, oshima@, jwd@, can you help review? Thanks.

[oshima, 2017-04-06 23:04:07]

lgtm with nits (just keep the same order where possible)

https://codereview.chromium.org/2802783002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/accessibility_manager.h (right):

https://codereview.chromium.org/2802783002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.h:54:
ACCESSIBILITY_TOGGLE_STICKY_KEYS,
keep the same order?

https://codereview.chromium.org/2802783002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.h:155: void
EnableTapDragging(bool enabled);
the order

https://codereview.chromium.org/2802783002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.h:158: bool
IsTapDraggingEnabled();
const?

pls update other IsXxx (separate CL is fine)

https://codereview.chromium.org/2802783002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.h:320: void
UpdateTapDraggingFromPref();
nit: move this between UpdateSelect.. and UpdateSwitch... to keep the same
order.

[jwd, 2017-04-07 17:44:17]

metrics LGTM

[minch1, 2017-04-07 18:34:14]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 18:34:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[minch1, 2017-04-07 19:11:23]

Description was changed from

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

This cl adds four functions in AccessibilityDelegate abstract class. This is
used to show above two a11y features in system menu.

BUG=632107
==========

to

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

Changes in this CL,

1. Add four functions in AccessibilityDelegate interface.
   This is used to show above two a11y features in system menu.

BUG=632107
==========

[commit-bot: I haz the power, 2017-04-07 19:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:16:44]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-04-07 19:17:23]

The CQ bit was checked by minch@chromium.org

[minch1, 2017-04-07 19:17:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, oshima@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2802783002/#ps20001
(title: "Address the comments on PS#1")

[commit-bot: I haz the power, 2017-04-07 19:17:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:30:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491592643256500,
"parent_rev": "b3d846d907794a018dca0793f45320064dc882f8", "commit_rev":
"d9d54248e86613a858bc8cefacd5725fd9aafc7f"}

[commit-bot: I haz the power, 2017-04-07 19:30:53]

Description was changed from

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

Changes in this CL,

1. Add four functions in AccessibilityDelegate interface.
   This is used to show above two a11y features in system menu.

BUG=632107
==========

to

==========
List all a11y features in a11y detailed view in ash system menu

1. Sticky keys
2. Tap dragging

Changes in this CL,

1. Add four functions in AccessibilityDelegate interface.
   This is used to show above two a11y features in system menu.

BUG=632107

Review-Url: https://codereview.chromium.org/2802783002
Cr-Commit-Position: refs/heads/master@{#462961}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9d54248e86613a858bc8cefacd5...
==========

[commit-bot: I haz the power, 2017-04-07 19:30:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9d54248e86613a858bc8cefacd5...