Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2802753002: Include ':' before constructor separators into AST with Fasta. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include ':' before constructor separators into AST with Fasta. R=paulberry@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c9407b4544a41e45c786a0fca115d7bd0a40d381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-05 16:29:15 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-05 19:43:45 UTC) #2
scheglov
3 years, 8 months ago (2017-04-05 20:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9407b4544a41e45c786a0fca115d7bd0a40d381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698