Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 2802753002: Include ':' before constructor separators into AST with Fasta. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/fasta/ast_builder.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index b508125cb23e6391bd03a984b12b30d928ef5656..464de0916e126c8da279ea73ca2bf1b888098138 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -54,13 +54,6 @@ class ClassMemberParserTest_Fasta extends FastaParserTestCase
with ClassMemberParserTestMixin {
@override
@failingTest
- void test_parseClassMember_constructor_withInitializers() {
- // TODO(paulberry): 'this' can't be used here.
- super.test_parseClassMember_constructor_withInitializers();
- }
-
- @override
- @failingTest
void test_parseClassMember_method_generic_comment_returnType() {
// TODO(paulberry): Fasta doesn't support generic comment syntax
super.test_parseClassMember_method_generic_comment_returnType();
@@ -832,16 +825,6 @@ class ParserProxy implements analyzer.Parser {
return _run((parser) => parser.parseUnit) as CompilationUnit;
}
- @override
- ConstructorFieldInitializer parseConstructorFieldInitializer(bool hasThis) {
- // Fasta's parser doesn't need the [hasThis] hint, so we ignore it.
- var colon = new fasta.SymbolToken(fasta.COLON_INFO, 0);
- colon.next = _currentFastaToken;
- _currentFastaToken = colon;
- var initializers = _run((parser) => parser.parseInitializers) as List;
- return initializers[0] as ConstructorFieldInitializer;
- }
-
/**
* Runs a single parser function, and returns the result as an analyzer AST.
*/
« no previous file with comments | « pkg/analyzer/lib/src/fasta/ast_builder.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698