Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2802743002: [Web Payments] Fix view clipping when updating content. (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Fix view clipping when updating content. BUG=707252 Review-Url: https://codereview.chromium.org/2802743002 Cr-Commit-Position: refs/heads/master@{#462234} Committed: https://chromium.googlesource.com/chromium/src/+/12af4f53a6107c5c80252666c804fb5a262b01bf

Patch Set 1 #

Patch Set 2 : Let the hierarchy own the content view. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/views/payments/payment_request_sheet_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
anthonyvd
Hi Math, PTAL!
3 years, 8 months ago (2017-04-05 16:22:49 UTC) #4
Mathieu
lgtm
3 years, 8 months ago (2017-04-05 16:26:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802743002/1
3 years, 8 months ago (2017-04-05 16:53:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/422524)
3 years, 8 months ago (2017-04-05 17:39:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802743002/20001
3 years, 8 months ago (2017-04-05 21:46:26 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 21:58:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12af4f53a6107c5c80252666c804...

Powered by Google App Engine
This is Rietveld 408576698