Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2802733002: headless: Require headless team review for mojo changes (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
Reviewers:
Eric Seckler
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Require headless team review for mojo changes The headless team should be aware of changes that affect either the C++ implementation or JS bindings of mojo services. BUG=546953 Review-Url: https://codereview.chromium.org/2802733002 Cr-Commit-Position: refs/heads/master@{#462105} Committed: https://chromium.googlesource.com/chromium/src/+/3f4ab462d9bdaae2d2049d798694083b959a8703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -39 lines) Patch
M headless/lib/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M headless/lib/embedder_mojo_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A headless/test/data/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A + headless/test/data/mojo_page_one.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + headless/test/data/mojo_page_two.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D headless/test/data/page_one.html View 1 chunk +0 lines, -19 lines 0 comments Download
D headless/test/data/page_two.html View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Sami
3 years, 8 months ago (2017-04-05 15:31:57 UTC) #4
Eric Seckler
lgtm
3 years, 8 months ago (2017-04-05 15:36:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802733002/1
3 years, 8 months ago (2017-04-05 16:18:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:29:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f4ab462d9bdaae2d2049d798694...

Powered by Google App Engine
This is Rietveld 408576698