Add default shadow to keyboard window

Add default shadow to keyboard window


BUG=370412
TEST=
1. open virtual keyboard in google.com
2. virtual keyboard window should have the default shadow

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269915

[bshe, 2014-05-12 15:05:58]

Hi Kevin.

Do you mind to take a look at this CL?

Thanks

[kevers, 2014-05-12 16:15:01]

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
File ui/keyboard/keyboard_controller_proxy.cc (right):

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
ui/keyboard/keyboard_controller_proxy.cc:178: shadow_->layer());
Has the impact of the size change been tested with the a11y keyboard?

[bshe, 2014-05-12 16:24:42]

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
File ui/keyboard/keyboard_controller_proxy.cc (right):

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
ui/keyboard/keyboard_controller_proxy.cc:178: shadow_->layer());
I tried a11y keyboard and the shadow seems work fine with resize (manually
change the bounds of linux_chromeos window size). The shadow shouldn't change
the keyboard bounds. Do you have a specific case that you worry about? I could
do test and see if it works.

On 2014/05/12 16:15:02, kevers wrote:
> Has the impact of the size change been tested with the a11y keyboard?

[kevers, 2014-05-12 17:10:18]

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
File ui/keyboard/keyboard_controller_proxy.cc (right):

https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
ui/keyboard/keyboard_controller_proxy.cc:178: shadow_->layer());
On 2014/05/12 16:24:43, bshe wrote:
> I tried a11y keyboard and the shadow seems work fine with resize (manually
> change the bounds of linux_chromeos window size). The shadow shouldn't change
> the keyboard bounds. Do you have a specific case that you worry about? I could
> do test and see if it works.
> 
> On 2014/05/12 16:15:02, kevers wrote:
> > Has the impact of the size change been tested with the a11y keyboard?
> 

My main concern was whether the top shadow overlapping a window would make
horizontal scrolling difficult at the bottom edge of the window.

[bshe, 2014-05-12 17:26:23]

On 2014/05/12 17:10:18, kevers wrote:
>
https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
> File ui/keyboard/keyboard_controller_proxy.cc (right):
> 
>
https://codereview.chromium.org/280273002/diff/20001/ui/keyboard/keyboard_con...
> ui/keyboard/keyboard_controller_proxy.cc:178: shadow_->layer());
> On 2014/05/12 16:24:43, bshe wrote:
> > I tried a11y keyboard and the shadow seems work fine with resize (manually
> > change the bounds of linux_chromeos window size). The shadow shouldn't
change
> > the keyboard bounds. Do you have a specific case that you worry about? I
could
> > do test and see if it works.
> > 
> > On 2014/05/12 16:15:02, kevers wrote:
> > > Has the impact of the size change been tested with the a11y keyboard?
> > 
> 
> My main concern was whether the top shadow overlapping a window would make
> horizontal scrolling difficult at the bottom edge of the window.

From my experiment, it doesn't seem to affect the horizontal scroll. And once I
click on the horizontal
scroll bar, keyboard dismissed due to focus lost. It could cause problem with
a11y keyboard for maximized
window. As the window will restore bounds and move the scroll bar away from
mouse cursor. But this is a
different issue.

[kevers, 2014-05-12 19:39:36]

lgtm

[bshe, 2014-05-12 19:55:07]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-05-12 19:55:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bshe@chromium.org/280273002/20001

[commit-bot: I haz the power, 2014-05-12 23:45:55]

Change committed as 269915