Add default shadow to keyboard window

ui/keyboard/keyboard_controller_proxy.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/keyboard_controller_proxy.h"
 
 #include "base/command_line.h"
 #include "base/values.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/bindings_policy.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/window.h"
 #include "ui/keyboard/keyboard_constants.h"
 #include "ui/keyboard/keyboard_switches.h"
 #include "ui/keyboard/keyboard_util.h"
+#include "ui/wm/core/shadow.h"
 
 namespace {
 
 // The WebContentsDelegate for the keyboard.
 // The delegate deletes itself when the keyboard is destroyed.
 class KeyboardContentsDelegate : public content::WebContentsDelegate,
                                  public content::WebContentsObserver {
  public:
   KeyboardContentsDelegate(keyboard::KeyboardControllerProxy* proxy)
       : proxy_(proxy) {}
@@ skipping 81 matching lines @@
 aura::Window* KeyboardControllerProxy::GetKeyboardWindow() {
   if (!keyboard_contents_) {
     content::BrowserContext* context = GetBrowserContext();
     keyboard_contents_.reset(content::WebContents::Create(
         content::WebContents::CreateParams(context,
             content::SiteInstance::CreateForURL(context,
                                                 GetVirtualKeyboardUrl()))));
     keyboard_contents_->SetDelegate(new KeyboardContentsDelegate(this));
     SetupWebContents(keyboard_contents_.get());
     LoadContents(GetVirtualKeyboardUrl());
+    keyboard_contents_->GetNativeView()->AddObserver(this);
   }
 
   return keyboard_contents_->GetNativeView();
 }
 
 bool KeyboardControllerProxy::HasKeyboardWindow() const {
   return keyboard_contents_;
 }
 
 void KeyboardControllerProxy::ShowKeyboardContainer(aura::Window* container) {
@@ skipping 24 matching lines @@
 void KeyboardControllerProxy::ReloadKeyboardIfNeeded() {
   DCHECK(keyboard_contents_);
   if (keyboard_contents_->GetURL() != GetVirtualKeyboardUrl()) {
     LoadContents(GetVirtualKeyboardUrl());
   }
 }
 
 void KeyboardControllerProxy::SetupWebContents(content::WebContents* contents) {
 }
 
+void KeyboardControllerProxy::OnWindowBoundsChanged(
+    aura::Window* window,
+    const gfx::Rect& old_bounds,
+    const gfx::Rect& new_bounds) {
+  if (!shadow_) {
+    shadow_.reset(new wm::Shadow());
+    shadow_->Init(wm::Shadow::STYLE_ACTIVE);
+    shadow_->layer()->SetVisible(true);
+    DCHECK(keyboard_contents_->GetNativeView()->parent());
+    keyboard_contents_->GetNativeView()->parent()->layer()->Add(
+        shadow_->layer());

[kevers, 2014/05/12 16:15:02]

Has the impact of the size change been tested with the a11y keyboard?

[bshe, 2014/05/12 16:24:43]

I tried a11y keyboard and the shadow seems work fine with resize (manually
change the bounds of linux_chromeos window size). The shadow shouldn't change
the keyboard bounds. Do you have a specific case that you worry about? I could
do test and see if it works.

On 2014/05/12 16:15:02, kevers wrote:

[kevers, 2014/05/12 17:10:18]

My main concern was whether the top shadow overlapping a window would make
horizontal scrolling difficult at the bottom edge of the window.

+  }
+
+  shadow_->SetContentBounds(new_bounds);
+}
+
+void KeyboardControllerProxy::OnWindowDestroyed(aura::Window* window) {
+  window->RemoveObserver(this);
+}
+
 }  // namespace keyboard