Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2802723003: MD Bookmarks: Remove 'enter' handler from Add/Edit dialog (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Remove 'enter' handler from Add/Edit dialog Following https://crrev.com/461814, cr-dialog now automatically accepts when enter is pressed with a paper-input focused. This CL reverts https://crrev.com/459706, removing the now duplicated event handler. BUG=692821 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2802723003 Cr-Commit-Position: refs/heads/master@{#462415} Committed: https://chromium.googlesource.com/chromium/src/+/15cf6391043873e64d75e9b40b549cbe5314aea5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/resources/md_bookmarks/edit_dialog.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/edit_dialog.js View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/edit_dialog_test.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tsergeant
3 years, 8 months ago (2017-04-06 03:29:57 UTC) #6
calamity
lgtm
3 years, 8 months ago (2017-04-06 08:14:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802723003/1
3 years, 8 months ago (2017-04-06 10:31:58 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 10:38:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15cf6391043873e64d75e9b40b54...

Powered by Google App Engine
This is Rietveld 408576698