Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2802723002: Rename duplicate symbols inside core/dom (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename duplicate symbols inside core/dom While experimenting with unity builds I got into problems with code that used the same symbol name for multiple purposes. This renames those which also will make the life for symbol debugging slightly easier. kSupplementName: Name used in both CSSSelectorWatch.cpp and DocumentParserTiming.cpp. WTF::Unicode symbols: Depending on how unity builds are created, global "using" statements can affect more than intended and trigger warnings and errors. Now global "using" statements are not allowed by the Chromium coding standard so assuming it will eventually apply to Blink as well, the using statements might as well be removed now. previousAncestorSiblingPostOrder was a function in both FlatTreeTraversal.cpp and NodeTraversal.cpp. Could easily be made class local and the name collision was no more. Review-Url: https://codereview.chromium.org/2802723002 Cr-Commit-Position: refs/heads/master@{#462123} Committed: https://chromium.googlesource.com/chromium/src/+/805ba25019edb994b874d506cff773134d06a970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 7 chunks +23 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeTraversal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeTraversal.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fs
lgtm
3 years, 8 months ago (2017-04-05 15:10:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802723002/1
3 years, 8 months ago (2017-04-05 15:17:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/389001)
3 years, 8 months ago (2017-04-05 15:31:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802723002/1
3 years, 8 months ago (2017-04-05 16:04:25 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 17:06:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/805ba25019edb994b874d506cff7...

Powered by Google App Engine
This is Rietveld 408576698