DescriptionRename duplicate symbols inside core/dom
While experimenting with unity builds I got into problems with
code that used the same symbol name for multiple purposes. This
renames those which also will make the life for symbol debugging
slightly easier.
kSupplementName: Name used in both CSSSelectorWatch.cpp and
DocumentParserTiming.cpp.
WTF::Unicode symbols: Depending on how unity builds are created,
global "using" statements can affect more than intended and trigger
warnings and errors. Now global "using" statements are not allowed by
the Chromium coding standard so assuming it will eventually apply to
Blink as well, the using statements might as well be removed now.
previousAncestorSiblingPostOrder was a function in both
FlatTreeTraversal.cpp and NodeTraversal.cpp. Could easily be made
class local and the name collision was no more.
Review-Url: https://codereview.chromium.org/2802723002
Cr-Commit-Position: refs/heads/master@{#462123}
Committed: https://chromium.googlesource.com/chromium/src/+/805ba25019edb994b874d506cff773134d06a970
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|