chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc - Issue 2802703004: Log creation for many dialog box types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

Issue 2802703004: Log creation for many dialog box types. (Closed)

Patch Set: qualify RecordDialogCreation with chrome:: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/critical_notification_bubble_view.cc ('K') | « chrome/browser/ui/views/crypto_module_password_dialog_view.cc ('k') | chrome/browser/ui/views/download/download_feedback_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

index 8667fee5fdbdefa0deff8ac226903beb92c52267..52a60ce2c31ffb8e70f1720d2c6049f630817bf9 100644

--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

@@ -6,6 +6,7 @@

#include "base/callback.h"

#include "chrome/browser/media/webrtc/desktop_media_list.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h"

@@ -217,6 +218,7 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(

widget = DialogDelegate::CreateDialogWidget(this, context, nullptr);

widget->Show();

}

+ chrome::RecordDialogCreation(chrome::DialogIdentifier::SCREENSHARE);

msw 2017/04/07 10:31:09 Hmm, a name closer to the class might be more appr

// If the picker is not modal to the calling web contents then it is displayed

// in its own top-level window, so in that case it needs to be filtered out of