Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5790)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/critical_notification_bubble_view.cc

Issue 2802703004: Log creation for many dialog box types. (Closed)
Patch Set: qualify RecordDialogCreation with chrome:: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/confirm_bubble_views.cc ('K') | « chrome/browser/ui/views/conflicting_module_view_win.cc ('k') | chrome/browser/ui/views/crypto_module_password_dialog_view.cc » ('j') | chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/critical_notification_bubble_view.cc
diff --git a/chrome/browser/ui/views/critical_notification_bubble_view.cc b/chrome/browser/ui/views/critical_notification_bubble_view.cc
index 372e2ff97c733ecf2861a055cccdc8fccd5130ac..1784a0184746b53ac47f78efda83b126b1c90f8f 100644
--- a/chrome/browser/ui/views/critical_notification_bubble_view.cc
+++ b/chrome/browser/ui/views/critical_notification_bubble_view.cc
@@ -8,6 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/upgrade_detector.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/chromium_strings.h"
@@ -44,6 +45,8 @@ CriticalNotificationBubbleView::CriticalNotificationBubbleView(
views::View* anchor_view)
: BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT) {
set_close_on_deactivate(false);
+ chrome::RecordDialogCreation(
+ chrome::DialogIdentifier::CRITICAL_UPGRADE_INSTALLED);
msw 2017/04/07 10:31:09 I vaguely recall this bubble being used for more t
}
CriticalNotificationBubbleView::~CriticalNotificationBubbleView() {
« chrome/browser/ui/views/confirm_bubble_views.cc ('K') | « chrome/browser/ui/views/conflicting_module_view_win.cc ('k') | chrome/browser/ui/views/crypto_module_password_dialog_view.cc » ('j') | chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698