Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2802703002: [ObjC ARC] Converts ios/chrome/browser/ui:test_support to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2802703002 Cr-Commit-Position: refs/heads/master@{#462829} Committed: https://chromium.googlesource.com/chromium/src/+/93ca4d5f576787997917557eb88e77b452d15425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_testing.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
stkhapugin
ptal
3 years, 8 months ago (2017-04-05 15:20:07 UTC) #6
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-06 08:26:38 UTC) #7
stkhapugin
Thank you!
3 years, 8 months ago (2017-04-07 09:25:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802703002/1
3 years, 8 months ago (2017-04-07 09:26:02 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 10:27:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93ca4d5f576787997917557eb88e...

Powered by Google App Engine
This is Rietveld 408576698