Add a comment and DCHECK to require |session_storage| to be non-nil in WebState::CreateWithStorageS…

Add a comment and DCHECK to require |session_storage| to be non-nil in
WebState::CreateWithStorageSession().

Because it looks passing nil doesn't work. Alternatively I can update
the code to make CreateWithStorageSession(params, nil) to be equivalent
of Create(params) if you prefer.

Background:
I wrote code to expect that CreateWithStorageSession(params, nil) is
equivalent of Create(params), resulted in a weird error.

Review-Url: https://codereview.chromium.org/2802613005
Cr-Commit-Position: refs/heads/master@{#462766}
Committed: https://chromium.googlesource.com/chromium/src/+/8ffc347519321c9cb2bc53ce5961bf69fff1903f

[Hiroshi Ichikawa, 2017-04-06 08:17:01]

Description was changed from

==========
Add a comment and DCHECK to require |session_storage| to be non-nil in
WebState::CreateWithStorageSession().
==========

to

==========
Add a comment and DCHECK to require |session_storage| to be non-nil in
WebState::CreateWithStorageSession().

Because it looks passing nil doesn't work. Alternatively I can update
the code to make CreateWithStorageSession(params, nil) to be equivalent
of Create(params) if you prefer.

Background:
I wrote code to expect that CreateWithStorageSession(params, nil) is
equivalent of Create(params), resulted in a weird error.
==========

[Hiroshi Ichikawa, 2017-04-06 08:17:40]

ichikawa@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2017-04-06 13:59:13]

lgtm

[Hiroshi Ichikawa, 2017-04-07 02:24:24]

The CQ bit was checked by ichikawa@chromium.org

[commit-bot: I haz the power, 2017-04-07 02:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:22:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491531864177360, "parent_rev":
"32282552b2ecb8eadce9a55f9c96003a1e82d707", "commit_rev":
"8ffc347519321c9cb2bc53ce5961bf69fff1903f"}

[commit-bot: I haz the power, 2017-04-07 05:23:38]

Description was changed from

==========
Add a comment and DCHECK to require |session_storage| to be non-nil in
WebState::CreateWithStorageSession().

Because it looks passing nil doesn't work. Alternatively I can update
the code to make CreateWithStorageSession(params, nil) to be equivalent
of Create(params) if you prefer.

Background:
I wrote code to expect that CreateWithStorageSession(params, nil) is
equivalent of Create(params), resulted in a weird error.
==========

to

==========
Add a comment and DCHECK to require |session_storage| to be non-nil in
WebState::CreateWithStorageSession().

Because it looks passing nil doesn't work. Alternatively I can update
the code to make CreateWithStorageSession(params, nil) to be equivalent
of Create(params) if you prefer.

Background:
I wrote code to expect that CreateWithStorageSession(params, nil) is
equivalent of Create(params), resulted in a weird error.

Review-Url: https://codereview.chromium.org/2802613005
Cr-Commit-Position: refs/heads/master@{#462766}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ffc347519321c9cb2bc53ce5961...
==========

[commit-bot: I haz the power, 2017-04-07 05:23:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ffc347519321c9cb2bc53ce5961...