Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/closure_compiler/interfaces/system_display_interface.js

Issue 2802603005: MD Settings: Display: Add unified desktop control and modify api (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/interfaces/system_display_interface.js
diff --git a/third_party/closure_compiler/interfaces/system_display_interface.js b/third_party/closure_compiler/interfaces/system_display_interface.js
index 84542264215dded21b6d17d1000c8d468621679d..db3f7ec4964662ce2730a78f576f037c8b81c050 100644
--- a/third_party/closure_compiler/interfaces/system_display_interface.js
+++ b/third_party/closure_compiler/interfaces/system_display_interface.js
@@ -24,6 +24,15 @@ SystemDisplay.prototype = {
getInfo: assertNotReached,
/**
+ * Get the layout info for all displays. NOTE: This is only available to
+ * Chrome OS Kiosk apps and Web UI.
+ * @param {function(!Array<!chrome.system.display.DisplayLayout>):void}
+ * callback
+ * @see https://developer.chrome.com/extensions/system.display#method-getDisplayLayout
+ */
+ getDisplayLayout: assertNotReached,
+
+ /**
* Updates the properties for the display specified by |id|, according to the
* information provided in |info|. On failure, $(ref:runtime.lastError) will
* be set. NOTE: This is only available to Chrome OS Kiosk apps and Web UI.
@@ -42,8 +51,13 @@ SystemDisplay.prototype = {
* Set the layout for all displays. Any display not included will use the
* default layout. If a layout would overlap or be otherwise invalid it will
* be adjusted to a valid layout. After layout is resolved, an
- * onDisplayChanged event will be triggered.
- * @param {!Array<!chrome.system.display.DisplayLayout>} layouts
+ * onDisplayChanged event will be triggered. NOTE: This is only available to
+ * Chrome OS Kiosk apps and Web UI.
+ * @param {!Array<!chrome.system.display.DisplayLayout>} layouts The layout
+ * information, required for all displays except the primary display.
+ * @param {function():void=} callback Empty function called when the function
+ * finishes. To find out whether the function succeeded,
+ * $(ref:runtime.lastError) should be queried.
xiyuan 2017/04/05 21:41:45 nit: fix the extra spaces ?
stevenjb 2017/04/06 01:56:09 ditto
* @see https://developer.chrome.com/extensions/system.display#method-setDisplayLayout
*/
setDisplayLayout: assertNotReached,
@@ -96,10 +110,15 @@ SystemDisplay.prototype = {
overscanCalibrationComplete: assertNotReached,
/**
- * Starts native touch calibration for a display. This will show an overlay on
- * the screen and initialize the UX for touch calibration. If another native
- * touch calibration is already in progress this will throw an error.
+ * Displays the native touch calibration UX for the display with |id| as
+ * display id. This will show an overlay on the screen with required
+ * instructions on how to proceed. The callback will be invoked in case of
+ * successful calibraion only. If the calibration fails, this will throw an
+ * error.
* @param {string} id The display's unique identifier.
+ * @param {function(boolean):void=} callback Optional callback to inform the
+ * caller that the touch calibration has ended. The argument of the
+ * callback informs if the calibration was a success or not.
xiyuan 2017/04/05 21:41:45 nit: fix extra spaces ?
stevenjb 2017/04/06 01:56:09 ditto
* @see https://developer.chrome.com/extensions/system.display#method-showNativeTouchCalibration
*/
showNativeTouchCalibration: assertNotReached,
@@ -129,8 +148,9 @@ SystemDisplay.prototype = {
completeCustomTouchCalibration: assertNotReached,
/**
- * Resets the touch calibration for the display and removes the saved
- * calibration data.
+ * Resets the touch calibration for the display and brings it back to its
+ * default state by clearing any touch calibration data associated with the
+ * display.
* @param {string} id The display's unique identifier.
* @see https://developer.chrome.com/extensions/system.display#method-clearTouchCalibration
*/

Powered by Google App Engine
This is Rietveld 408576698