Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/closure_compiler/externs/system_display.js

Issue 2802603005: MD Settings: Display: Add unified desktop control and modify api (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/externs/system_display.js
diff --git a/third_party/closure_compiler/externs/system_display.js b/third_party/closure_compiler/externs/system_display.js
index a37c094e174c75f9e972d40a6992a080ec6a0c97..c798264c7d55747f6654c3bc4ae0a6f9a40df024 100644
--- a/third_party/closure_compiler/externs/system_display.js
+++ b/third_party/closure_compiler/externs/system_display.js
@@ -117,6 +117,7 @@ chrome.system.display.DisplayLayout;
* isPrimary: boolean,
* isInternal: boolean,
* isEnabled: boolean,
+ * isUnified: boolean,
* dpiX: number,
* dpiY: number,
* rotation: number,
@@ -238,13 +239,17 @@ chrome.system.display.overscanCalibrationReset = function(id) {};
chrome.system.display.overscanCalibrationComplete = function(id) {};
/**
- * Starts native touch calibration for a display. This will show an overlay on
- * the screen and initialize the UX for touch calibration. If another native
- * touch calibration is already in progress this will throw an error.
+ * Displays the native touch calibration UX for the display with |id| as display
+ * id. This will show an overlay on the screen with required instructions on how
+ * to proceed. The callback will be invoked in case of successful calibraion
+ * only. If the calibration fails, this will throw an error.
* @param {string} id The display's unique identifier.
+ * @param {function(boolean):void=} callback Optional callback to inform the
+ * caller that the touch calibration has ended. The argument of the
xiyuan 2017/04/05 21:41:45 nit: The space between "touch" and "calibration" h
stevenjb 2017/04/06 01:56:09 This is generated.
+ * callback informs if the calibration was a success or not.
* @see https://developer.chrome.com/extensions/system.display#method-showNativeTouchCalibration
*/
-chrome.system.display.showNativeTouchCalibration = function(id) {};
+chrome.system.display.showNativeTouchCalibration = function(id, callback) {};
/**
* Starts custom touch calibration for a display. This should be called when
@@ -264,15 +269,16 @@ chrome.system.display.startCustomTouchCalibration = function(id) {};
* @param {!chrome.system.display.TouchCalibrationPairQuad} pairs The pairs of
* point used to calibrate the display.
* @param {!chrome.system.display.Bounds} bounds Bounds of the display when the
- * touch calibration was performed. |bounds.left| and |bounds.top|
+ * touch calibration was performed. |bounds.left| and |bounds.top|
xiyuan 2017/04/05 21:41:45 nit: remove extra spaces ?
stevenjb 2017/04/06 01:56:09 ditto.
* values are ignored.
* @see https://developer.chrome.com/extensions/system.display#method-completeCustomTouchCalibration
*/
chrome.system.display.completeCustomTouchCalibration = function(pairs, bounds) {};
/**
- * Resets the touch calibration for the display and removes the saved
- * calibration data.
+ * Resets the touch calibration for the display and brings it back to its
+ * default state by clearing any touch calibration data associated with the
+ * display.
* @param {string} id The display's unique identifier.
* @see https://developer.chrome.com/extensions/system.display#method-clearTouchCalibration
*/

Powered by Google App Engine
This is Rietveld 408576698