Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2802593004: Move RarePaintData to its own file (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RarePaintData to its own file This patch pulls RarePaintData out of LayoutObject so the paint data as it is only needed for paint things. This is just a refactoring and should have no observable effect. BUG=700452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2802593004 Cr-Commit-Position: refs/heads/master@{#462330} Committed: https://chromium.googlesource.com/chromium/src/+/d8c43f8e7d8c730a082122680008cdbf8b6ed43d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -139 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +2 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +2 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/Source/core/paint/RarePaintData.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/RarePaintData.cpp View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pdr.
3 years, 8 months ago (2017-04-05 22:24:06 UTC) #2
Xianzhu
lgtm
3 years, 8 months ago (2017-04-05 22:41:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802593004/1
3 years, 8 months ago (2017-04-05 22:50:03 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 02:27:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8c43f8e7d8c730a082122680008...

Powered by Google App Engine
This is Rietveld 408576698