Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2802593003: Add //net deps to content/public/common/referrer.typemap (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
palmer, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //net deps to content/public/common/referrer.typemap Also add OWNERS *.typemap rules that presubmit complained about. BUG=none Review-Url: https://codereview.chromium.org/2802593003 Cr-Commit-Position: refs/heads/master@{#462305} Committed: https://chromium.googlesource.com/chromium/src/+/d171113ba68ab33dc071c55d5c023d14328f453d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/public/common/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/referrer.typemap View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mattm
piman for OWNERS palmer for typemap (background at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/wA-4W0Dp5Rs)
3 years, 8 months ago (2017-04-05 22:24:12 UTC) #5
palmer
lgtm
3 years, 8 months ago (2017-04-05 22:55:45 UTC) #6
piman
lgtm
3 years, 8 months ago (2017-04-05 23:22:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802593003/1
3 years, 8 months ago (2017-04-06 00:57:16 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:07:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d171113ba68ab33dc071c55d5c02...

Powered by Google App Engine
This is Rietveld 408576698