Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2802583003: MD Settings: remove an import and some variables from early loading shim (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
esprehn
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove an import and some variables from early loading shim This makes pixels get to the screen EVEN faster! R=esprehn@chromium.org BUG=597347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2802583003 Cr-Commit-Position: refs/heads/master@{#462361} Committed: https://chromium.googlesource.com/chromium/src/+/b5a62f53a2a193d134dbd7392407979280829354

Patch Set 1 #

Patch Set 2 : class->attr #

Patch Set 3 : iwyu #

Patch Set 4 : attr->class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 2 3 1 chunk +5 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_vars_css.html View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Dan Beam
3 years, 8 months ago (2017-04-06 02:40:16 UTC) #3
esprehn
lgtm
3 years, 8 months ago (2017-04-06 04:03:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802583003/60001
3 years, 8 months ago (2017-04-06 04:11:32 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 05:26:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b5a62f53a2a193d134dbd7392407...

Powered by Google App Engine
This is Rietveld 408576698