Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2802493002: Revert of mac: Periodically shim new malloc zones immediately after startup. (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Periodically shim new malloc zones immediately after startup. (patchset #9 id:160001 of https://codereview.chromium.org/2713553002/ ) Reason for revert: Findit identified CL at revision 461836 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI0NWYxNzU1OWY5NzNiYjVhMjA3YzA2M2Q5ODJjMGJhYjBlYzFjMGIM Original issue's description: > mac: Periodically shim new malloc zones immediately after startup. > > On macOS, libraries lazily make malloc zones. There are no notifications when > this happens. This CL adds polling with an exponential backoff to check for the > existence of new malloc zones, stopping after 1 minute. > > This CL only has an affect when heap profiling is enabled. > > BUG=693237 > > Review-Url: https://codereview.chromium.org/2713553002 > Cr-Commit-Position: refs/heads/master@{#461836} > Committed: https://chromium.googlesource.com/chromium/src/+/245f17559f973bb5a207c063d982c0bab0ec1c0b TBR=primiano@chromium.org,mark@chromium.org,avi@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693237 Review-Url: https://codereview.chromium.org/2802493002 Cr-Commit-Position: refs/heads/master@{#461877} Committed: https://chromium.googlesource.com/chromium/src/+/ecc1d96e6789d172b45dd155ccdb26b631f1ecb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -173 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/allocator/allocator_interception_mac.h View 2 chunks +0 lines, -10 lines 0 comments Download
M base/allocator/allocator_interception_mac.mm View 3 chunks +38 lines, -78 lines 0 comments Download
D base/allocator/allocator_interception_mac_unittest.mm View 1 chunk +0 lines, -62 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
findit-for-me
Created Revert of mac: Periodically shim new malloc zones immediately after startup.
3 years, 8 months ago (2017-04-04 22:48:18 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-04 22:48:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802493002/1
3 years, 8 months ago (2017-04-04 22:50:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-04 22:50:17 UTC) #7
kelvinp
lgtm
3 years, 8 months ago (2017-04-04 22:50:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802493002/1
3 years, 8 months ago (2017-04-04 22:51:46 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 22:53:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecc1d96e6789d172b45dd155ccdb...

Powered by Google App Engine
This is Rietveld 408576698