Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2802473002: Include 'invokeMethodRef' reference as a linking dependency. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include 'invokeMethodRef' reference as a linking dependency. It was crashing with StackOverflow internally. With changes since the latest internal release it was not crashing, but still failing with assertion. This makes it fail with a correct error, without throwing an exception. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/03a0ee09436322e2d6609ba61dc88989faa18d60

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +6 lines, -1 line 1 comment Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-04 21:24:52 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2802473002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/2802473002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode4888 pkg/analyzer/lib/src/summary/link.dart:4888: // TODO(paulberry): if this reference refers to a ...
3 years, 8 months ago (2017-04-04 21:31:49 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 03a0ee09436322e2d6609ba61dc88989faa18d60 (presubmit successful).
3 years, 8 months ago (2017-04-04 21:36:02 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-04 21:37:33 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698