Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: pkg/analyzer/lib/src/summary/link.dart

Issue 2802473002: Include 'invokeMethodRef' reference as a linking dependency. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/linker_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/link.dart
diff --git a/pkg/analyzer/lib/src/summary/link.dart b/pkg/analyzer/lib/src/summary/link.dart
index 7d793315ee2f1dfccbbb04d2c5e3347f3ccaf5eb..01c196096a89c81ed6848698b1169b2f30f0ec57 100644
--- a/pkg/analyzer/lib/src/summary/link.dart
+++ b/pkg/analyzer/lib/src/summary/link.dart
@@ -4887,7 +4887,12 @@ class TypeInferenceNode extends Node<TypeInferenceNode> {
case UnlinkedExprOperation.invokeMethodRef:
// TODO(paulberry): if this reference refers to a variable, should it
Paul Berry 2017/04/04 21:31:48 We can get rid of this TODO now.
// be considered a type inference dependency?
- refPtr++;
+ EntityRef ref = unlinkedConst.references[refPtr++];
+ TypeInferenceNode dependency =
+ compilationUnit.resolveRef(ref.reference).asTypeInferenceNode;
+ if (dependency != null) {
+ dependencies.add(dependency);
+ }
intPtr += 2;
int numTypeArguments = unlinkedConst.ints[intPtr++];
refPtr += numTypeArguments;
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/linker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698