Adds feature flag for chrome-proxy-ect header (default off)

Adds feature flag for chrome-proxy-ect header (default off)

BUG=707981

[dougarnett, 2017-04-04 21:23:00]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2017-04-04 21:30:52]

dougarnett@chromium.org changed reviewers:
+ bengr@chromium.org, ryansturm@chromium.org

[dougarnett, 2017-04-04 21:30:53]

Please take a look at this approach of adding feature flag for ECT header. I
still need to fix up tests but wanted to see if I could get agreement from you
two first before spending much effort on that.

[RyanSturm, 2017-04-04 21:41:54]

On 2017/04/04 21:30:53, dougarnett wrote:
> Please take a look at this approach of adding feature flag for ECT header. I
> still need to fix up tests but wanted to see if I could get agreement from you
> two first before spending much effort on that.

It seems fine. I don't see a great reason to have a flag, but I don't know the
best way to keep this disabled on 59 and on for 60 without doing this approach
or ripping out relevant code. It seems like we really only need a command line
flag (i.e., don't expose this in about flags). I'd recommend splitting all
relevant tests into ECT flag and non-ECT flag versions though. Bengr, WDYT?

[dougarnett, 2017-04-05 18:53:40]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2017-04-05 18:55:34]

On 2017/04/04 21:41:54, Ryan Sturm wrote:
> On 2017/04/04 21:30:53, dougarnett wrote:
> > Please take a look at this approach of adding feature flag for ECT header. I
> > still need to fix up tests but wanted to see if I could get agreement from
you
> > two first before spending much effort on that.
> 
> It seems fine. I don't see a great reason to have a flag, but I don't know the
> best way to keep this disabled on 59 and on for 60 without doing this approach
> or ripping out relevant code. It seems like we really only need a command line
> flag (i.e., don't expose this in about flags). I'd recommend splitting all
> relevant tests into ECT flag and non-ECT flag versions though. Bengr, WDYT?

Removed the about_flags and flag_descriptions additions and got ECT unittest
working based on turning on scoped feature.

[commit-bot: I haz the power, 2017-04-05 19:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:53:07]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2017-04-05 23:19:59]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:21:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:07:19]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dougarnett, 2017-04-06 15:51:06]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 15:51:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:35:26]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2017-04-06 20:26:28]

Description was changed from

==========
Adds feature flag for chrome-proxy-ect header (default off)

BUG=707981
==========

to

==========
Adds feature flag for chrome-proxy-ect header (default off)

BUG=707981
==========

[dougarnett, 2017-04-06 20:26:29]

dougarnett@chromium.org changed reviewers:
- bengr@chromium.org, ryansturm@chromium.org