Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2802433002: do not allow built-in keywords to specified when refactoring (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

do not allow built-in keywords to specified when refactoring R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/99aefce48cf078790c2252ce4ed3937f1879763d

Patch Set 1 #

Patch Set 2 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 9 chunks +91 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 8 months ago (2017-04-04 20:36:09 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-04 21:01:52 UTC) #3
danrubel
3 years, 8 months ago (2017-04-04 21:13:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
99aefce48cf078790c2252ce4ed3937f1879763d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698