do not allow built-in keywords to specified when refactoring

pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.naming_conventions;
 
 import 'package:analysis_server/plugin/protocol/protocol.dart'
     show RefactoringProblemSeverity;
 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
@@ skipping 147 matching lines @@
         expectedMessage: "Field name must not contain '-'.");
   }
 
   void test_validateFieldName_notIdentifierStart() {
     assertRefactoringStatus(
         validateFieldName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Field name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateFieldName_notKeyword() {
+    assertRefactoringStatus(
+        validateFieldName("for"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Field name must not be a keyword.");
+  }
+
+  void test_validateFieldName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateFieldName("await"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Field name must not be a keyword.");
+  }
+
   void test_validateFieldName_null() {
     assertRefactoringStatus(
         validateFieldName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Field name must not be null.");
   }
 
   void test_validateFieldName_OK() {
     assertRefactoringStatusOK(validateFieldName("newName"));
   }
 
@@ skipping 35 matching lines @@
         expectedMessage: "Function name must not contain '-'.");
   }
 
   void test_validateFunctionName_notIdentifierStart() {
     assertRefactoringStatus(
         validateFunctionName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Function name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateFunctionName_notKeyword() {
+    assertRefactoringStatus(
+        validateFunctionName("new"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Function name must not be a keyword.");
+  }
+
+  void test_validateFunctionName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateFunctionName("yield"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Function name must not be a keyword.");
+  }
+
   void test_validateFunctionName_null() {
     assertRefactoringStatus(
         validateFunctionName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Function name must not be null.");
   }
 
   void test_validateFunctionName_OK() {
     assertRefactoringStatusOK(validateFunctionName("newName"));
   }
 
@@ skipping 97 matching lines @@
         expectedMessage: "Import prefix name must not contain '-'.");
   }
 
   void test_validateImportPrefixName_notIdentifierStart() {
     assertRefactoringStatus(
         validateImportPrefixName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Import prefix name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateImportPrefixName_notKeyword() {
+    assertRefactoringStatus(
+        validateImportPrefixName("while"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Import prefix name must not be a keyword.");
+  }
+
+  void test_validateImportPrefixName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateImportPrefixName("await"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Import prefix name must not be a keyword.");
+  }
+
   void test_validateImportPrefixName_null() {
     assertRefactoringStatus(
         validateImportPrefixName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Import prefix name must not be null.");
   }
 
   void test_validateImportPrefixName_OK() {
     assertRefactoringStatusOK(validateImportPrefixName("newName"));
   }
 
@@ skipping 36 matching lines @@
         expectedMessage: "Label name must not contain '-'.");
   }
 
   void test_validateLabelName_notIdentifierStart() {
     assertRefactoringStatus(
         validateLabelName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Label name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateLabelName_notKeyword() {
+    assertRefactoringStatus(
+        validateLabelName("for"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Label name must not be a keyword.");
+  }
+
+  void test_validateLabelName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateLabelName("await"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Label name must not be a keyword.");
+  }
+
   void test_validateLabelName_null() {
     assertRefactoringStatus(
         validateLabelName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Label name must not be null.");
   }
 
   void test_validateLabelName_OK() {
     assertRefactoringStatusOK(validateLabelName("newName"));
   }
 
@@ skipping 54 matching lines @@
         expectedMessage: "Library name identifier must not contain '-'.");
   }
 
   void test_validateLibraryName_notIdentifierStart() {
     assertRefactoringStatus(
         validateLibraryName("my.2bad.name"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Library name identifier must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateLibraryName_notKeyword() {
+    assertRefactoringStatus(
+        validateLibraryName("my.yield.name"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Library name identifier must not be a keyword.");
+  }
+
   void test_validateLibraryName_null() {
     assertRefactoringStatus(
         validateLibraryName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Library name must not be null.");
   }
 
   void test_validateLibraryName_OK_oneIdentifier() {
     assertRefactoringStatusOK(validateLibraryName("name"));
   }
 
   void test_validateLibraryName_OK_severalIdentifiers() {
-    assertRefactoringStatusOK(validateLibraryName("my.library.name"));
+    assertRefactoringStatusOK(validateLibraryName("my.lib.name"));
   }
 
   void test_validateLibraryName_trailingBlanks() {
     assertRefactoringStatus(
         validateLibraryName("my.bad .name"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Library name identifier must not start or end with a blank.");
   }
 
   void test_validateMethodName_doesNotStartWithLowerCase() {
@@ skipping 26 matching lines @@
         expectedMessage: "Method name must not contain '-'.");
   }
 
   void test_validateMethodName_notIdentifierStart() {
     assertRefactoringStatus(
         validateMethodName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Method name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateMethodName_notKeyword() {
+    assertRefactoringStatus(
+        validateMethodName("do"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Method name must not be a keyword.");
+  }
+
+  void test_validateMethodName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateMethodName("yield"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Method name must not be a keyword.");
+  }
+
   void test_validateMethodName_null() {
     assertRefactoringStatus(
         validateMethodName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Method name must not be null.");
   }
 
   void test_validateMethodName_OK() {
     assertRefactoringStatusOK(validateMethodName("newName"));
   }
 
@@ skipping 36 matching lines @@
         expectedMessage: "Parameter name must not contain '-'.");
   }
 
   void test_validateParameterName_notIdentifierStart() {
     assertRefactoringStatus(
         validateParameterName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Parameter name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateParameterName_notKeyword() {
+    assertRefactoringStatus(
+        validateParameterName("while"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Parameter name must not be a keyword.");
+  }
+
+  void test_validateParameterName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateParameterName("await"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Parameter name must not be a keyword.");
+  }
+
   void test_validateParameterName_null() {
     assertRefactoringStatus(
         validateParameterName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Parameter name must not be null.");
   }
 
   void test_validateParameterName_OK() {
     assertRefactoringStatusOK(validateParameterName("newName"));
   }
 
@@ skipping 35 matching lines @@
         expectedMessage: "Variable name must not contain '-'.");
   }
 
   void test_validateVariableName_notIdentifierStart() {
     assertRefactoringStatus(
         validateVariableName("2newName"), RefactoringProblemSeverity.FATAL,
         expectedMessage:
             "Variable name must begin with a lowercase letter or underscore.");
   }
 
+  void test_validateVariableName_notKeyword() {
+    assertRefactoringStatus(
+        validateVariableName("for"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Variable name must not be a keyword.");
+  }
+
+  void test_validateVariableName_notPseudoKeyword() {
+    assertRefactoringStatus(
+        validateVariableName("await"), RefactoringProblemSeverity.FATAL,
+        expectedMessage: "Variable name must not be a keyword.");
+  }
+
   void test_validateVariableName_null() {
     assertRefactoringStatus(
         validateVariableName(null), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Variable name must not be null.");
   }
 
   void test_validateVariableName_OK() {
     assertRefactoringStatusOK(validateVariableName("newName"));
   }
 
   void test_validateVariableName_OK_leadingDollar() {
     assertRefactoringStatusOK(validateVariableName("\$newName"));
   }
 
   void test_validateVariableName_OK_leadingUnderscore() {
     assertRefactoringStatusOK(validateVariableName("_newName"));
   }
 
   void test_validateVariableName_OK_middleUnderscore() {
     assertRefactoringStatusOK(validateVariableName("new_name"));
   }
 
   void test_validateVariableName_trailingBlanks() {
     assertRefactoringStatus(
         validateVariableName("newName "), RefactoringProblemSeverity.FATAL,
         expectedMessage: "Variable name must not start or end with a blank.");
   }
 }