Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2802423002: Rename safe_cmp::{Eq,Ne,Lt,Le,Ge,Gt} to Safe{Eq,Ne,Lt,Le,Ge,Gt} (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 5 months ago
Reviewers:
nisse-webrtc, ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename safe_cmp::{Eq,Ne,Lt,Le,Ge,Gt} to Safe{Eq,Ne,Lt,Le,Ge,Gt} For consistency with SafeMin(), SafeMax(), and SafeClamp(). And so that we avoid introducing a namespace. BUG=webrtc:7459 Review-Url: https://codereview.webrtc.org/2802423002 Cr-Commit-Position: refs/heads/master@{#18756} Committed: https://chromium.googlesource.com/external/webrtc/+/93ecc5dad05b6996ce42ead407ba0e769ce5b370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -338 lines) Patch
M webrtc/base/checks.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/safe_compare.h View 4 chunks +9 lines, -12 lines 0 comments Download
M webrtc/base/safe_compare_unittest.cc View 3 chunks +308 lines, -308 lines 0 comments Download
M webrtc/base/safe_minmax.h View 7 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
kwiberg-webrtc
3 years, 6 months ago (2017-06-13 12:54:27 UTC) #10
nisse-webrtc
lgtm
3 years, 6 months ago (2017-06-13 13:18:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2802423002/20001
3 years, 5 months ago (2017-06-26 03:05:37 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/19471)
3 years, 5 months ago (2017-06-26 03:29:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2802423002/20001
3 years, 5 months ago (2017-06-26 08:14:00 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 08:31:36 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/93ecc5dad05b6996ce42ead40...

Powered by Google App Engine
This is Rietveld 408576698