Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2802413002: Don't let current width affect preferred width on shrink-to-fit containers (Closed)

Created:
3 years, 8 months ago by rhogan
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't let current width affect preferred width on shrink-to-fit containers When shrinking-to-fit a container don't let the current width affect its preferred widths. This will happen if we let percent margins on child inlines calculate themselves against the block's current calculated width. To avoid this reset the container's width to zero so that percent margins are ignored in the preferred width calculation. BUG=598711 Review-Url: https://codereview.chromium.org/2802413002 Cr-Commit-Position: refs/heads/master@{#463378} Committed: https://chromium.googlesource.com/chromium/src/+/037075a489638e0c6d8adf4a25184949efd36c1d

Patch Set 1 #

Patch Set 2 : bug 598711 #

Patch Set 3 : bug 598711 #

Total comments: 1

Patch Set 4 : bug 598711 #

Patch Set 5 : bug 598711 #

Patch Set 6 : bug 598711 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/inline/percentage-margins-shrink-to-fit.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/inline/percentage-margins-shrink-to-fit-expected.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 27 (21 generated)
rhogan
3 years, 8 months ago (2017-04-09 10:32:13 UTC) #15
eae
LGTM https://codereview.chromium.org/2802413002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBox.cpp File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/2802413002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBox.cpp#newcode2729 third_party/WebKit/Source/core/layout/LayoutBox.cpp:2729: // use it when calculating min/max preferred width. ...
3 years, 8 months ago (2017-04-10 05:17:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802413002/80001
3 years, 8 months ago (2017-04-10 17:01:34 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/72597) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 17:05:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802413002/100001
3 years, 8 months ago (2017-04-10 18:29:48 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:12:38 UTC) #27
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/037075a489638e0c6d8adf4a2518...

Powered by Google App Engine
This is Rietveld 408576698