Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2802403002: Resolve current orientation after applying the previous orientation request. (Closed)

Created:
3 years, 8 months ago by oshima
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, jam, darin-cc_chromium.org, sadrul, kalyank
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Resolve current orientation after applying the previous orientation request. An application may request to lock to portrait (primary/secondary), the lock to specific orientation by sending CURRENT (no sensor/lock). Current implement does not support this scenario because it looks to the current device's orientation even if that orientation was for other apps. This CL addresses this issue by waiting until the window is activated. BUG=708202 TEST=covered by unit test, plus manual tests using sample app. Review-Url: https://codereview.chromium.org/2792973002 Cr-Commit-Position: refs/heads/master@{#462206} Committed: https://chromium.googlesource.com/chromium/src/+/4f5b7f72da4ca1534233252c673f9c162bdb25f9 Review-Url: https://codereview.chromium.org/2802403002 . Cr-Commit-Position: refs/branch-heads/3029@{#638} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -127 lines) Patch
M ash/content/screen_orientation_delegate_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 9 chunks +105 lines, -20 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 6 chunks +31 lines, -3 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 5 chunks +25 lines, -12 lines 0 comments Download
M ash/test/screen_orientation_controller_test_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/test/screen_orientation_controller_test_api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 7 chunks +42 lines, -30 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +1 line, -60 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
oshima
3 years, 8 months ago (2017-04-08 05:30:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b.

Powered by Google App Engine
This is Rietveld 408576698