Add ForceSigninVerifier.

Add ForceSigninVerifier. 

It will verify the auth token when a profile is loaded into memory via gaia server.
It only works when force-sign-in policy is enabled.

BUG=642059
Review-Url: https://codereview.chromium.org/2802373002
Cr-Commit-Position: refs/heads/master@{#463627}
Committed: https://chromium.googlesource.com/chromium/src/+/39fcf953558ac53836206883f1506638cd61a20a

[zmin, 2017-04-07 22:11:56]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[zmin, 2017-04-07 22:12:18]

Description was changed from

==========
Add ForceSigninVerifier. It will verify the auth token when a profile is loaded
into memory via gaia server.
It only works when force-sign-in policy is enabled.

BUG=642059
==========

to

==========
Add ForceSigninVerifier. 

It will verify the auth token when a profile is loaded into memory via gaia
server.
It only works when force-sign-in policy is enabled.

BUG=642059
==========

[commit-bot: I haz the power, 2017-04-07 22:12:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zmin, 2017-04-07 22:13:44]

zmin@chromium.org changed reviewers:
+ rogerta@chromium.org

[zmin, 2017-04-07 22:13:45]

Hi Roger,

Could you please review the CL?


Owen

[zmin, 2017-04-07 22:21:08]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:21:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:43:50]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roger Tawa OOO till Jul 10th, 2017-04-10 15:15:20]

lgtm with comments below.

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
File chrome/browser/signin/force_signin_verifier.cc (right):

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.cc:67:
access_token_request_.reset();
Would it be better to call Cancel() instead of lines 66-67?
Same for line 76.

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
File chrome/browser/signin/force_signin_verifier.h (right):

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:46: // Sent the token verification
request. The request will be sent only if
nit: Sent -> Send

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:56: // Show the warning dialog
before sign out user and close assoicated browser
Nit:
sign out -> signing out
close -> closing

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:66: base::OneShotTimer
backoff_request_timer_;
All data members should be private.  You can add accessor functions as either
public or protected.  Looking at the mock class, could probably put most of
those accessor functions in this class as public, except maybe the out that
returns the request, which could be left protected.

[zmin, 2017-04-10 19:27:37]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:28:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:42:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zmin, 2017-04-10 19:54:47]

Patchset #3 (id:40001) has been deleted

[zmin, 2017-04-10 19:56:26]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:56:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:12:15]

Dry run: This issue passed the CQ dry run.

[zmin, 2017-04-10 22:26:16]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 22:27:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zmin, 2017-04-10 22:27:49]

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
File chrome/browser/signin/force_signin_verifier.cc (right):

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.cc:67:
access_token_request_.reset();
On 2017/04/10 15:15:20, Roger Tawa wrote:
> Would it be better to call Cancel() instead of lines 66-67?
> Same for line 76.

Done.

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
File chrome/browser/signin/force_signin_verifier.h (right):

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:46: // Sent the token verification
request. The request will be sent only if
On 2017/04/10 15:15:20, Roger Tawa wrote:
> nit: Sent -> Send

Done.

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:56: // Show the warning dialog
before sign out user and close assoicated browser
On 2017/04/10 15:15:20, Roger Tawa wrote:
> Nit:
> sign out -> signing out
> close -> closing

Done.

https://codereview.chromium.org/2802373002/diff/20001/chrome/browser/signin/f...
chrome/browser/signin/force_signin_verifier.h:66: base::OneShotTimer
backoff_request_timer_;
On 2017/04/10 15:15:20, Roger Tawa wrote:
> All data members should be private.  You can add accessor functions as either
> public or protected.  Looking at the mock class, could probably put most of
> those accessor functions in this class as public, except maybe the out that
> returns the request, which could be left protected.

I create a public method for |has_token_verified_|.

For the rest, because all of them can't do copy and return, I have to return
pointer instead. So I write  getter functions for them under protector plus
'ForTesting' in naming to make sure that they are only used by test.

[commit-bot: I haz the power, 2017-04-11 00:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 00:14:36]

Dry run: This issue passed the CQ dry run.

[Roger Tawa OOO till Jul 10th, 2017-04-11 11:29:42]

lgtm

[zmin, 2017-04-11 14:37:49]

The CQ bit was checked by zmin@chromium.org

[commit-bot: I haz the power, 2017-04-11 14:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 14:43:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491921469715500,
"parent_rev": "d475452cb5ab8571fd8346ed0bf10be782b11c99", "commit_rev":
"39fcf953558ac53836206883f1506638cd61a20a"}

[commit-bot: I haz the power, 2017-04-11 14:44:28]

Description was changed from

==========
Add ForceSigninVerifier. 

It will verify the auth token when a profile is loaded into memory via gaia
server.
It only works when force-sign-in policy is enabled.

BUG=642059
==========

to

==========
Add ForceSigninVerifier. 

It will verify the auth token when a profile is loaded into memory via gaia
server.
It only works when force-sign-in policy is enabled.

BUG=642059

Review-Url: https://codereview.chromium.org/2802373002
Cr-Commit-Position: refs/heads/master@{#463627}
Committed:
https://chromium.googlesource.com/chromium/src/+/39fcf953558ac53836206883f150...
==========

[commit-bot: I haz the power, 2017-04-11 14:44:30]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/39fcf953558ac53836206883f150...