Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2802343002:
Fix static initializers in CrasAudioHandler. (Closed)
DescriptionFix static initializers in CrasAudioHandler.
BUG=537099
Review-Url: https://codereview.chromium.org/2802343002
Cr-Commit-Position: refs/heads/master@{#465399}
Committed: https://chromium.googlesource.com/chromium/src/+/a9ee1ac2ffca6fe5d05f0283820ddb1673c2f197
Patch Set 1 #Patch Set 2 : Just the fix #
Total comments: 2
Messages
Total messages: 20 (9 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + jennyz@chromium.org
static initializers are from r384173
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jennyz: ping
On 2017/04/13 04:25:30, Lei Zhang wrote: > jennyz: ping There is lots of unrelated codes changes other than fixing static intializers in CrasAudioHandler. Can we separate them out from this cl?
On 2017/04/18 21:21:33, jennyz wrote: > On 2017/04/13 04:25:30, Lei Zhang wrote: > > jennyz: ping > > There is lots of unrelated codes changes other than fixing static intializers in > CrasAudioHandler. Can we separate them out from this cl? Sure. Can you just look at lines 40-42, and lines 437-443 and let me know if that looks ok? I'll upload another patch set shortly.
Description was changed from ========== Fix static initializers in CrasAudioHandler. Simplify code as well. BUG=537099 ========== to ========== Fix static initializers in CrasAudioHandler. BUG=537099 ==========
Uploaded patch set 2.
On 2017/04/18 21:21:33, jennyz wrote: > On 2017/04/13 04:25:30, Lei Zhang wrote: > > jennyz: ping > > There is lots of unrelated codes changes other than fixing static intializers in > CrasAudioHandler. Can we separate them out from this cl? These lines looks good :-)
On 2017/04/18 21:32:55, jennyz wrote: > These lines looks good :-) Can you el gee tee emm patch set 2 then? :)
https://codereview.chromium.org/2802343002/diff/20001/chromeos/audio/cras_aud... File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2802343002/diff/20001/chromeos/audio/cras_aud... chromeos/audio/cras_audio_handler.cc:434: ->GetCrasAudioClient() BTW, this is clang-format rewriting code however it likes. I will do the cleanup CL after this CL lands, and that will shorten this quite a bit.
lgtm https://codereview.chromium.org/2802343002/diff/20001/chromeos/audio/cras_aud... File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2802343002/diff/20001/chromeos/audio/cras_aud... chromeos/audio/cras_audio_handler.cc:434: ->GetCrasAudioClient() On 2017/04/18 21:35:51, Lei Zhang wrote: > BTW, this is clang-format rewriting code however it likes. I will do the cleanup > CL after this CL lands, and that will shorten this quite a bit. Acknowledged.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492552241816700,
"parent_rev": "218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9", "commit_rev":
"a9ee1ac2ffca6fe5d05f0283820ddb1673c2f197"}
Message was sent while issue was closed.
Description was changed from ========== Fix static initializers in CrasAudioHandler. BUG=537099 ========== to ========== Fix static initializers in CrasAudioHandler. BUG=537099 Review-Url: https://codereview.chromium.org/2802343002 Cr-Commit-Position: refs/heads/master@{#465399} Committed: https://chromium.googlesource.com/chromium/src/+/a9ee1ac2ffca6fe5d05f0283820d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a9ee1ac2ffca6fe5d05f0283820d... |
