Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/core/paint/PaintTiming.cpp

Issue 2802313002: DevTools: do not report paint metrics under blink.user_timing category. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintTiming.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintTiming.cpp b/third_party/WebKit/Source/core/paint/PaintTiming.cpp
index 65940300c13a52fb12ba2fea3210ac24c0417ded..12a6b6d9d9b20e63b6731f04ab2ae9e77a63f5e6 100644
--- a/third_party/WebKit/Source/core/paint/PaintTiming.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintTiming.cpp
@@ -67,7 +67,7 @@ void PaintTiming::markFirstTextPaint() {
m_firstTextPaint = monotonicallyIncreasingTime();
setFirstContentfulPaint(m_firstTextPaint);
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "blink.user_timing,rail", "firstTextPaint",
+ "rail,devtools.timeline", "firstTextPaint",
TraceEvent::toTraceTimestamp(m_firstTextPaint), "frame", frame());
notifyPaintTimingChanged();
}
@@ -78,7 +78,7 @@ void PaintTiming::markFirstImagePaint() {
m_firstImagePaint = monotonicallyIncreasingTime();
setFirstContentfulPaint(m_firstImagePaint);
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "blink.user_timing,rail", "firstImagePaint",
+ "rail,devtools.timeline", "firstImagePaint",
TraceEvent::toTraceTimestamp(m_firstImagePaint), "frame", frame());
notifyPaintTimingChanged();
}
@@ -96,7 +96,7 @@ void PaintTiming::setFirstMeaningfulPaint(double stamp) {
DCHECK_EQ(m_firstMeaningfulPaint, 0.0);
m_firstMeaningfulPaint = stamp;
TRACE_EVENT_MARK_WITH_TIMESTAMP1(
- "blink.user_timing", "firstMeaningfulPaint",
+ "rail,devtools.timeline", "firstMeaningfulPaint",
TraceEvent::toTraceTimestamp(m_firstMeaningfulPaint), "frame", frame());
notifyPaintTimingChanged();
}
@@ -139,7 +139,7 @@ void PaintTiming::setFirstPaint(double stamp) {
if (performance)
performance->addFirstPaintTiming(m_firstPaint);
- TRACE_EVENT_INSTANT1("blink.user_timing,rail", "firstPaint",
+ TRACE_EVENT_INSTANT1("rail,devtools.timeline", "firstPaint",
TRACE_EVENT_SCOPE_PROCESS, "frame", frame());
}
@@ -151,7 +151,7 @@ void PaintTiming::setFirstContentfulPaint(double stamp) {
Performance* performance = getPerformanceInstance(frame());
if (performance)
performance->addFirstContentfulPaintTiming(m_firstContentfulPaint);
- TRACE_EVENT_INSTANT1("blink.user_timing,rail", "firstContentfulPaint",
+ TRACE_EVENT_INSTANT1("rail,devtools.timeline", "firstContentfulPaint",
pfeldman 2017/04/07 19:02:33 I only found this one mentioned in catapult, but I
TRACE_EVENT_SCOPE_PROCESS, "frame", frame());
}
« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698