third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp - Issue 2802313002: DevTools: do not report paint metrics under blink.user_timing category.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

Issue 2802313002: DevTools: do not report paint metrics under blink.user_timing category. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

index 6c203a14c8f0de1b9dc47771f7f93a6bdf46020a..af68985017b311798e3508a1578ea9ae9786c020 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

@@ -99,7 +99,7 @@ void FirstMeaningfulPaintDetector::notifyPaint() {

return;

TRACE_EVENT_MARK_WITH_TIMESTAMP1(

- "loading", "firstMeaningfulPaintCandidate",

+ "loading,devtools.timeline", "firstMeaningfulPaintCandidate",

TraceEvent::toTraceTimestamp(m_provisionalFirstMeaningfulPaint), "frame",

document()->frame());

// Ignore the first meaningful paint candidate as this generally is the first

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintTiming.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintTiming.cpp » ('J')