Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2802243002: Guard native notification code under ENABLE_NATIVE_NOTIFICATIONS guards (Closed)

Created:
9 months, 2 weeks ago by tonikitoo
Modified:
9 months, 2 weeks ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, msisov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard native notification code under ENABLE_NATIVE_NOTIFICATIONS guards about_flags.cc today opt in/out configurations manually, rather than using the existing ENABLE_NATIVE_NOTIFICATIONS build flag. This fixes the OZONE/Linux build. BUG=676220 R=thomasanderson@google.com Review-Url: https://codereview.chromium.org/2802243002 Cr-Commit-Position: refs/heads/master@{#462896} Committed: https://chromium.googlesource.com/chromium/src/+/09fb058d6bfb0e74343a851f56e4032c44b56c19

Patch Set 1 #

Patch Set 2 : Guard native notification code under ENABLE_NATIVE_NOTIFICATIONS guards #

Patch Set 3 : Ignore #

Patch Set 4 : Guard native notification code under ENABLE_NATIVE_NOTIFICATIONS guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tonikitoo
PTAL
9 months, 2 weeks ago (2017-04-07 15:26:12 UTC) #1
Tom Anderson
lgtm
9 months, 2 weeks ago (2017-04-07 16:20:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802243002/60001
9 months, 2 weeks ago (2017-04-07 16:54:56 UTC) #12
commit-bot: I haz the power
9 months, 2 weeks ago (2017-04-07 17:01:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/09fb058d6bfb0e74343a851f56e4...

Powered by Google App Engine
This is Rietveld 408576698