Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2802233002: [Media Controls] Temporarily disable failing metrics tests on Android (Closed)

Created:
3 years, 8 months ago by johnme
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, Elly Fong-Jones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Controls] Temporarily disable failing metrics tests on Android The timeline width seems to differ. https://crbug.com/709483 tracks re-enabling these. BUG=709483 TBR=mlamouri@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2802233002 Cr-Commit-Position: refs/heads/master@{#462863} Committed: https://chromium.googlesource.com/chromium/src/+/fc14e3a2a3e43bacbca4b48f0ba3e66b4af9a50a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp View 4 chunks +32 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
johnme
3 years, 8 months ago (2017-04-07 14:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802233002/1
3 years, 8 months ago (2017-04-07 14:58:24 UTC) #5
Elly Fong-Jones
lgtm
3 years, 8 months ago (2017-04-07 14:59:23 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:05:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc14e3a2a3e43bacbca4b48f0ba3...

Powered by Google App Engine
This is Rietveld 408576698