Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2802173002:
Test changes for accLocation to confirm that transformations work. (Closed)
|
Created:
3 years, 8 months ago by dougt Modified:
3 years, 8 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionTest for accLocation to confirm that transformations work.
BUG=703369
Review-Url: https://codereview.chromium.org/2802173002
Cr-Commit-Position: refs/heads/master@{#463149}
Committed: https://chromium.googlesource.com/chromium/src/+/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d
Patch Set 1 #
Total comments: 4
Patch Set 2 : Test changes for accLocation to confirm that transformations work. #
Messages
Total messages: 31 (23 generated)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Test changes for accLocation to confirm that transformations work. BUG= ========== to ========== Test for accLocation to confirm that transformations work. BUG=703369 ==========
dougt@chromium.org changed reviewers: + dmazzoni@chromium.org
dmazzoni, PTAL. I recall you mentioning that ROLE_SYSTEM_DOCUMENT may be flaky on windows. Is there a way to repro that issue, or do you think we should just change the diffing to exclude ROLE_SYSTEM_DOCUMENT lines?
https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... File content/test/data/accessibility/html/iframe-transform-expected-win.txt (right): https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... content/test/data/accessibility/html/iframe-transform-expected-win.txt:1: ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE location=(0, 0) size=(783, 800) This one will be flaky, make the location/size explicit so that this one isn't there https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... File content/test/data/accessibility/html/iframe-transform.html (right): https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... content/test/data/accessibility/html/iframe-transform.html:4: @WIN-ALLOW:transform I don't think this exists
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dmazzoni, ptal https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... File content/test/data/accessibility/html/iframe-transform-expected-win.txt (right): https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... content/test/data/accessibility/html/iframe-transform-expected-win.txt:1: ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE location=(0, 0) size=(783, 800) On 2017/04/07 20:28:19, dmazzoni wrote: > This one will be flaky, make the location/size explicit so that this one isn't > there Done. https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... File content/test/data/accessibility/html/iframe-transform.html (right): https://codereview.chromium.org/2802173002/diff/1/content/test/data/accessibi... content/test/data/accessibility/html/iframe-transform.html:4: @WIN-ALLOW:transform On 2017/04/07 20:28:19, dmazzoni wrote: > I don't think this exists Done.
The CQ bit was checked by dmazzoni@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dougt@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491755723116260,
"parent_rev": "c30f6366d7a44d731032fdcf3532a97e80007a9a", "commit_rev":
"bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d"}
Message was sent while issue was closed.
Description was changed from ========== Test for accLocation to confirm that transformations work. BUG=703369 ========== to ========== Test for accLocation to confirm that transformations work. BUG=703369 Review-Url: https://codereview.chromium.org/2802173002 Cr-Commit-Position: refs/heads/master@{#463149} Committed: https://chromium.googlesource.com/chromium/src/+/bc2ea45ec4b3b2d9d426182d5927... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bc2ea45ec4b3b2d9d426182d5927... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
