Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2802163002: Removed CRWWebControllerInvalidUrlTest.LoadInvalidURL. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CRWWebControllerInvalidUrlTest.LoadInvalidURL. This test executes code path which is not used in the real app and hence is not useful. BUG=709290 Review-Url: https://codereview.chromium.org/2802163002 Cr-Commit-Position: refs/heads/master@{#462907} Committed: https://chromium.googlesource.com/chromium/src/+/5717606707c4bdae7710dc382b3f687e713830f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-07 03:26:39 UTC) #3
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-07 17:16:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802163002/1
3 years, 8 months ago (2017-04-07 17:17:00 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:22:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5717606707c4bdae7710dc382b3f...

Powered by Google App Engine
This is Rietveld 408576698