Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2802153002: Fix bug in request-init-003.sub.html (Closed)

Created:
3 years, 8 months ago by yiyix
Modified:
3 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug in request-init-003.sub.html According to the Fetch spec, the Request constructor is called with |input| only, then referrer attribute will be set to "about:client". From fetch spec, https://fetch.spec.whatwg.org/#concept-request: Unless the referrer is set to anther value in request, it is set to "about:client" by default. BUG=624278 Review-Url: https://codereview.chromium.org/2802153002 Cr-Commit-Position: refs/heads/master@{#462811} Committed: https://chromium.googlesource.com/chromium/src/+/3602528ca6d0a7b9bf3b8569c1974ced69249eb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-003.sub.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-003.sub-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
yiyix
@falken, could you please review this change? thank you.
3 years, 8 months ago (2017-04-07 02:02:49 UTC) #3
falken
Could you link to the spec and quote the relevant section in the bug description? ...
3 years, 8 months ago (2017-04-07 02:56:08 UTC) #4
yiyix
On 2017/04/07 02:56:08, falken wrote: > Could you link to the spec and quote the ...
3 years, 8 months ago (2017-04-07 06:58:37 UTC) #6
falken
I think this is right. lgtm. nits in CL description: s/the service worker spec/the Fetch ...
3 years, 8 months ago (2017-04-07 07:08:21 UTC) #7
yiyix
On 2017/04/07 07:08:21, falken wrote: > I think this is right. lgtm. > > nits ...
3 years, 8 months ago (2017-04-07 07:40:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802153002/1
3 years, 8 months ago (2017-04-07 07:40:45 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 08:41:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3602528ca6d0a7b9bf3b8569c197...

Powered by Google App Engine
This is Rietveld 408576698