Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2802093009: Remove MessageLoop destruction observer from hid_connection_win.cc (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
fdoray
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop destruction observer from hid_connection_win.cc PendingHidTransfer does not need to be a MessageLoop destruction observer because these objects live on the main thread and are freed synchronously when the HidConnectionWin is closed. BUG=650723 Review-Url: https://codereview.chromium.org/2802093009 Cr-Commit-Position: refs/heads/master@{#463283} Committed: https://chromium.googlesource.com/chromium/src/+/2cd83da8d67df6634cb770c559f7e588b5ae25b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M device/hid/hid_connection_win.cc View 6 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 8 months ago (2017-04-08 01:20:51 UTC) #2
fdoray
lgtm
3 years, 8 months ago (2017-04-10 12:35:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802093009/1
3 years, 8 months ago (2017-04-10 15:07:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 16:09:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cd83da8d67df6634cb770c559f7...

Powered by Google App Engine
This is Rietveld 408576698