Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2802093008:
Rename android_webview_apk and android_webview_test_apk (Closed)
|
Created:
3 years, 8 months ago by Shimi Zhang Modified:
3 years, 8 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org, wnwen+watch_chromium.org, nyquist+watch_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, sgurun-gerrit only Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRename android_webview_apk and android_webview_test_apk
To webview_instrumentation_apk and webview_instrumentation_test_apk
BUG=701938
Review-Url: https://codereview.chromium.org/2802093008
Cr-Commit-Position: refs/heads/master@{#466368}
Committed: https://chromium.googlesource.com/chromium/src/+/34f54d6d0964d6dcd779482a884819dcf973c05f
Patch Set 1 #Patch Set 2 : change more mk files #Patch Set 3 : use template #Patch Set 4 : rebase #
Messages
Total messages: 33 (24 generated)
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [WIP] Rename android_webview_apk and android_webview_test_apk BUG=701938 ========== to ========== Rename android_webview_apk and android_webview_test_apk To webview_instrumentation_apk and webview_instrumentation_test_apk BUG=701938 ==========
ctzsm@chromium.org changed reviewers: + agrieve@chromium.org, michaelbai@chromium.org
ctzsm@chromium.org changed reviewers: + dpranke@chromium.org, jbudorick@chromium.org
PTAL, michaelbai@ for android_webview, agrieve@ for build, dpranke@ for docs/android_cast_build_instructions.md, jbudorick@ for docs/android_test_instructions.md. The next step for this task to me is going to change corresponding names in json files under build/scripts/slave/recipe_modules/chromium_android/example.expected/, jbudorick@, any suggestion?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2017/04/20 22:33:08, Shimi Zhang wrote: > PTAL, > > michaelbai@ for android_webview, > agrieve@ for build, > dpranke@ for docs/android_cast_build_instructions.md, > jbudorick@ for docs/android_test_instructions.md. lgtm > > The next step for this task to me is going to change corresponding names in json > files under > build/scripts/slave/recipe_modules/chromium_android/example.expected/, > jbudorick@, any suggestion? https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c... You'll also want to rename all instances of android_webview_test_apk in //testing/buildbot/, though that can wait for a later CL.
agrieve@chromium.org changed reviewers: + torne@chromium.org - agrieve@chromium.org, michaelbai@chromium.org
On 2017/04/21 00:32:13, jbudorick wrote: > On 2017/04/20 22:33:08, Shimi Zhang wrote: > > PTAL, > > > > michaelbai@ for android_webview, > > agrieve@ for build, > > dpranke@ for docs/android_cast_build_instructions.md, > > jbudorick@ for docs/android_test_instructions.md. > > lgtm > > > > > The next step for this task to me is going to change corresponding names in > json > > files under > > build/scripts/slave/recipe_modules/chromium_android/example.expected/, > > jbudorick@, any suggestion? > > https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c... > > You'll also want to rename all instances of android_webview_test_apk in > //testing/buildbot/, though that can wait for a later CL. -self and michaelbai (ooo). +torne
lgtm
The CQ bit was checked by ctzsm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492793766399650,
"parent_rev": "f0866591722f897f56030eface6ba0ba7b76c62a", "commit_rev":
"34f54d6d0964d6dcd779482a884819dcf973c05f"}
Message was sent while issue was closed.
Description was changed from ========== Rename android_webview_apk and android_webview_test_apk To webview_instrumentation_apk and webview_instrumentation_test_apk BUG=701938 ========== to ========== Rename android_webview_apk and android_webview_test_apk To webview_instrumentation_apk and webview_instrumentation_test_apk BUG=701938 Review-Url: https://codereview.chromium.org/2802093008 Cr-Commit-Position: refs/heads/master@{#466368} Committed: https://chromium.googlesource.com/chromium/src/+/34f54d6d0964d6dcd779482a8848... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/34f54d6d0964d6dcd779482a8848...
Message was sent while issue was closed.
Thank you for review guys! Thank you for pointing out //testing/buildbot/, jbudorick@.
Message was sent while issue was closed.
michaelbai@chromium.org changed reviewers: + michaelbai@chromium.org
Message was sent while issue was closed.
android_webview LGTM |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
