Have ActiveProfilePrefService Use the Original Profile

Have ActiveProfilePrefService Use the Original Profile

ActiveProfilePrefService attempts to bind connections to the active profile.
However Incognito profiles do not register with the preference service. This
was leading to ServiceManagerConnectionImpl rejecting the connection, as there
was no registered service.

This change switches to using the original profile for the connection. Incognito
profile is backed by a base ProfileImpl. All ProfileImpl properly register as a
service.

This change also reenables the ash::shell connection to the pref service.

This change also reverts https://codereview.chromium.org/2795413002 which was
landed to deal with possible race condition of request handlers. However this
was not the root cause.

TESTING=device actually boots now, ash::shell receives its connection to prefs.
User can login.
BUG=707321
Review-Url: https://codereview.chromium.org/2802093005
Cr-Commit-Position: refs/heads/master@{#462997}
Committed: https://chromium.googlesource.com/chromium/src/+/c4ba106074379b272a5a33bde847ec1db40383bf

[jonross, 2017-04-07 17:09:38]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-04-07 17:09:38]

Hey sky@

Could you take a look at this review? It's an update to the preferences
connections based on our discussions yesterday.

Thanks,
Jon

[sky, 2017-04-07 17:24:00]

LGTM

[jonross, 2017-04-07 17:34:27]

jonross@chromium.org changed reviewers:
+ ben@chromium.org

[jonross, 2017-04-07 17:34:28]

ben@chromium.org: Please review changes in 

content/common/service_manager/service_manager_connection_impl.cc	

I'm reverting the changes you reviews in
https://codereview.chromium.org/2795413002 as they are no longer needed.

Thanks,
Jon

[Ben Goodger (Google), 2017-04-07 19:38:28]

lgtm

[jonross, 2017-04-07 19:39:41]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:40:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:51:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491593981947510, "parent_rev":
"01af1ced7632270acaeeb0f4f684eee3ea6cd415", "commit_rev":
"9cfd47f81999ce9d709a7365ab798cdcb08e1afc"}

[commit-bot: I haz the power, 2017-04-07 20:56:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491593981947510, "parent_rev":
"d7e1c1dbdf7eaf191ffdc371a0282648502f487d", "commit_rev":
"c4ba106074379b272a5a33bde847ec1db40383bf"}

[commit-bot: I haz the power, 2017-04-07 20:57:16]

Description was changed from

==========
Have ActiveProfilePrefService Use the Original Profile

ActiveProfilePrefService attempts to bind connections to the active profile.
However Incognito profiles do not register with the preference service. This
was leading to ServiceManagerConnectionImpl rejecting the connection, as there
was no registered service.

This change switches to using the original profile for the connection. Incognito
profile is backed by a base ProfileImpl. All ProfileImpl properly register as a
service.

This change also reenables the ash::shell connection to the pref service.

This change also reverts https://codereview.chromium.org/2795413002 which was
landed to deal with possible race condition of request handlers. However this
was not the root cause.

TESTING=device actually boots now, ash::shell receives its connection to prefs.
User can login.
BUG=707321
==========

to

==========
Have ActiveProfilePrefService Use the Original Profile

ActiveProfilePrefService attempts to bind connections to the active profile.
However Incognito profiles do not register with the preference service. This
was leading to ServiceManagerConnectionImpl rejecting the connection, as there
was no registered service.

This change switches to using the original profile for the connection. Incognito
profile is backed by a base ProfileImpl. All ProfileImpl properly register as a
service.

This change also reenables the ash::shell connection to the pref service.

This change also reverts https://codereview.chromium.org/2795413002 which was
landed to deal with possible race condition of request handlers. However this
was not the root cause.

TESTING=device actually boots now, ash::shell receives its connection to prefs.
User can login.
BUG=707321

Review-Url: https://codereview.chromium.org/2802093005
Cr-Commit-Position: refs/heads/master@{#462997}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4ba106074379b272a5a33bde847...
==========

[commit-bot: I haz the power, 2017-04-07 20:57:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4ba106074379b272a5a33bde847...