Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2802093002: Add -f flag to git cl upload when uploading patchset in wpt importer (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add -f flag to git cl upload when uploading patchset in wpt importer The last couple import jobs failed when uploading the second patchset; I think that it failed at this point (and not when uploading the CL initially) because when initially uploading the CL it uses -f. We want to use -f in general to ignore presubmit warnings for things like tabs. Review-Url: https://codereview.chromium.org/2802093002 Cr-Commit-Position: refs/heads/master@{#462698} Committed: https://chromium.googlesource.com/chromium/src/+/65b779860c2fbcda49066ea532c5cb3178fdc65e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 8 months ago (2017-04-06 20:06:29 UTC) #2
jeffcarp
lgtm
3 years, 8 months ago (2017-04-06 20:09:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802093002/1
3 years, 8 months ago (2017-04-06 22:01:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:10:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65b779860c2fbcda49066ea532c5...

Powered by Google App Engine
This is Rietveld 408576698