Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2802073002: MD Settings: Focus the container, instead of settings-main, when sidenav is closed. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Focus the container, instead of settings-main, when sidenav is closed. This fixes a regression where the scroll position changed after closing the sidenav, and is more correct, since the container is the scroll target. BUG=708960 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2802073002 Cr-Commit-Position: refs/heads/master@{#462913} Committed: https://chromium.googlesource.com/chromium/src/+/c3257e6eb48627fde7ad129012ee9904110e4969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
dpapad
3 years, 8 months ago (2017-04-06 18:48:10 UTC) #5
dpapad
On 2017/04/06 at 18:48:10, dpapad wrote: > Friendly ping. Based on our discussion yesterday, let's ...
3 years, 8 months ago (2017-04-07 16:51:13 UTC) #11
Dan Beam
lgtm
3 years, 8 months ago (2017-04-07 17:22:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802073002/1
3 years, 8 months ago (2017-04-07 17:23:22 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:40:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3257e6eb48627fde7ad129012ee...

Powered by Google App Engine
This is Rietveld 408576698