Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2802033002: Sets the Pay button's title color to white. (Closed)

Created:
3 years, 8 months ago by macourteau
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Sets the Pay button's title color to white. This method only sets the color for non-disabled states: https://cs.chromium.org/chromium/src/ios/third_party/material_components_ios/src/components/Buttons/src/MDCButton.h?l=69 BUG=602666 Review-Url: https://codereview.chromium.org/2802033002 Cr-Commit-Position: refs/heads/master@{#462866} Committed: https://chromium.googlesource.com/chromium/src/+/513ae0b635d0b5a278fec01a61e7623c76a18184

Patch Set 1 #

Patch Set 2 : Switch to MDCButton. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M ios/chrome/browser/payments/payment_request_view_controller.mm View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
macourteau
3 years, 8 months ago (2017-04-06 15:18:38 UTC) #2
macourteau
Switched to using MDCButton, PTAL.
3 years, 8 months ago (2017-04-07 15:19:05 UTC) #3
Moe
On 2017/04/07 15:19:05, macourteau wrote: > Switched to using MDCButton, PTAL. lgtm
3 years, 8 months ago (2017-04-07 15:25:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802033002/20001
3 years, 8 months ago (2017-04-07 15:30:59 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:36:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/513ae0b635d0b5a278fec01a61e7...

Powered by Google App Engine
This is Rietveld 408576698