Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2802003003: [builtins] Speed up TypedArrayInitialize in CodeStubAssembler (Closed)

Created:
3 years, 8 months ago by ivica.bogosavljevic
Modified:
3 years, 8 months ago
CC:
v8-mips-ports_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Speed up TypedArrayInitialize in CodeStubAssembler On those architectures that do support unaligned memory access there is no need to emit heap alignment code in TypedArrayInitialize. BUG=chromium:708545 Review-Url: https://codereview.chromium.org/2802003003 Cr-Commit-Position: refs/heads/master@{#44501} Committed: https://chromium.googlesource.com/v8/v8/+/d9691952c1825ca9c8f73db5f63f842da9226cd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/builtins/builtins-typedarray-gen.cc View 1 chunk +11 lines, -1 line 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
ivica.bogosavljevic
PTAL
3 years, 8 months ago (2017-04-06 13:35:16 UTC) #3
Camillo Bruni
lgtm
3 years, 8 months ago (2017-04-06 14:20:55 UTC) #5
petermarshall
lgtm
3 years, 8 months ago (2017-04-06 14:22:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802003003/1
3 years, 8 months ago (2017-04-07 12:58:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38722)
3 years, 8 months ago (2017-04-07 13:02:49 UTC) #14
ivica.bogosavljevic
Need lgtm from code-assembler file owner
3 years, 8 months ago (2017-04-07 13:04:05 UTC) #16
Benedikt Meurer
LGTM (rubber-stamped)
3 years, 8 months ago (2017-04-07 17:31:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802003003/1
3 years, 8 months ago (2017-04-08 21:05:34 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 22:15:47 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d9691952c1825ca9c8f73db5f63f842da92...

Powered by Google App Engine
This is Rietveld 408576698