Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2801983003: Switching WebRTC browser test from AudioManager::HasAudioOutputDevices() to AudioSystem interface. (Closed)

Created:
3 years, 8 months ago by o1ka
Modified:
3 years, 8 months ago
CC:
audio-mojo-cl_google.com, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, Max Morin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching WebRTC browser test from AudioManager::HasAudioOutputDevices() to AudioSystem interface. BUG=672468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801983003 Cr-Commit-Position: refs/heads/master@{#462859} Committed: https://chromium.googlesource.com/chromium/src/+/e1920d9dc4d5cb935cbf0f27c0e5beb06c8a0c25

Patch Set 1 #

Patch Set 2 : moved HasAudioOutputDevices() to WebRtcContentBrowserTestBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -6 lines) Patch
M content/browser/webrtc/webrtc_audio_browsertest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M content/browser/webrtc/webrtc_content_browsertest_base.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/webrtc/webrtc_content_browsertest_base.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M media/audio/audio_system.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M media/audio/audio_system_impl_unittest.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
o1ka
PTAL
3 years, 8 months ago (2017-04-06 13:31:16 UTC) #6
Max Morin
lgtm. Might make sense to put HasAudioOutputDevices in WebRtcContentBrowserTestBase?
3 years, 8 months ago (2017-04-06 13:41:45 UTC) #7
o1ka
On 2017/04/06 13:41:45, Max Morin wrote: > lgtm. Might make sense to put HasAudioOutputDevices in ...
3 years, 8 months ago (2017-04-06 13:56:01 UTC) #8
Guido Urdaneta
lgtm
3 years, 8 months ago (2017-04-06 13:56:13 UTC) #9
Guido Urdaneta
still lgtm
3 years, 8 months ago (2017-04-06 13:56:56 UTC) #10
o1ka
Thanks Max and Guido. Dale - could you RS?
3 years, 8 months ago (2017-04-06 14:07:57 UTC) #12
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-06 19:19:17 UTC) #13
o1ka
On 2017/04/06 19:19:17, DaleCurtis wrote: > lgtm Thanks Dale.
3 years, 8 months ago (2017-04-07 09:02:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801983003/20001
3 years, 8 months ago (2017-04-07 09:03:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/7556)
3 years, 8 months ago (2017-04-07 11:35:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801983003/20001
3 years, 8 months ago (2017-04-07 12:05:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/7563)
3 years, 8 months ago (2017-04-07 14:43:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801983003/20001
3 years, 8 months ago (2017-04-07 14:48:17 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 14:53:31 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1920d9dc4d5cb935cbf0f27c0e5...

Powered by Google App Engine
This is Rietveld 408576698