Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2801893004: Avoid duplicate functions/code in core/editing: kUnsetCodePoint (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicate functions/code in core/editing: kUnsetCodePoint While experimenting with unity builds I encountered a few duplicate symbols and functions in core/editing. This patch renames, moves and unifies them. kInvalidCodePoint is used in both ForwardGraphemeBoundaryStateMachine and BackwardGraphemeBoundaryStateMachine so to avoid clashes, use different names for them. BUG=708949 R=yosin@chromium.org Review-Url: https://codereview.chromium.org/2801893004 Cr-Commit-Position: refs/heads/master@{#462423} Committed: https://chromium.googlesource.com/chromium/src/+/96ea303ff0f2ed2bc7fa35387c0f1b85b1fc0e40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Daniel Bratell
Please take a look.
3 years, 8 months ago (2017-04-06 07:44:23 UTC) #1
Daniel Bratell
Please take a look.
3 years, 8 months ago (2017-04-06 07:44:36 UTC) #3
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-06 09:58:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801893004/1
3 years, 8 months ago (2017-04-06 09:58:31 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:26:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96ea303ff0f2ed2bc7fa35387c0f...

Powered by Google App Engine
This is Rietveld 408576698