Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2801883002: Dynamically attach VrShellDelegate to the most recently resumed supported Activity. (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Dynamically attach VrShellDelegate to the most recently resumed supported Activity. This CL moves some of the refactoring out https://codereview.chromium.org/2776243007/ to simplify that already complicated CL. BUG=698754 Review-Url: https://codereview.chromium.org/2801883002 Cr-Commit-Position: refs/heads/master@{#463478} Committed: https://chromium.googlesource.com/chromium/src/+/7198dc47acec10e7f5ee3be1eebb8f3d26560e8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 7 chunks +34 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 8 months ago (2017-04-06 14:12:28 UTC) #2
bshe
On 2017/04/06 14:12:28, mthiesse wrote: > PTAL lgtm
3 years, 8 months ago (2017-04-10 22:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801883002/1
3 years, 8 months ago (2017-04-10 23:46:14 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:58:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7198dc47acec10e7f5ee3be1eebb...

Powered by Google App Engine
This is Rietveld 408576698